loading-skeleton #83

Open

klaipras wants to merge 21 commits from loading-skeleton into ui_change

pull from: loading-skeleton

merge into: ScottyLabs:ui_change

ScottyLabs:main

ScottyLabs:renovate/lockfiles

ScottyLabs:renovate/kennel

ScottyLabs:issue-09

ScottyLabs:ui_change

ScottyLabs:issue-42-unblock-user-button-style

ScottyLabs:fix/course-api-host

ScottyLabs:auth-routing

ScottyLabs:dark-mode-fix

ScottyLabs:update-readme

ScottyLabs:kennel-test

ScottyLabs:move-to-kennel

ScottyLabs:add-workflow-docs

ScottyLabs:fix-auth-redirect-uri

ScottyLabs:feature/28-account-details-priority

ScottyLabs:fix-api-call

ScottyLabs:consolidate-workflow

ScottyLabs:purposes_dropdown

ScottyLabs:test-join

ScottyLabs:fix-faculty-check-restored

ScottyLabs:fix-faculty-check

ScottyLabs:revert-22-fix-faculty-check

ScottyLabs:feature/new-ui

ScottyLabs:feat/mobile-nav-bar

ScottyLabs:postgres

ScottyLabs:dev

ScottyLabs:refactor

ScottyLabs:auth

ScottyLabs:vercel/react-server-components-cve-vu-qudffl

ScottyLabs:faculty

ScottyLabs:card-info-popup

ScottyLabs:faculty_page

ScottyLabs:gcal

ScottyLabs:blocking

ScottyLabs:editable

ScottyLabs:fixed-filterbar

ScottyLabs:posthog

ScottyLabs:feedback-form

ScottyLabs:Navbar-edits

ScottyLabs:stage

ScottyLabs:Edit-Group-Button

ScottyLabs:mobile-fix

ScottyLabs:wraparound_for_popup

ScottyLabs:Profile-Pop-Up

ScottyLabs:messaging

Conversation 2 Commits 21 Files changed 9 +290 -42

klaipras commented 2026-10-25 04:13:57 +00:00

Member

Copy link

Description

add loading skeleton into the feed/my-group pages by adding "loading" variable to data fetching hook. This pr also come with some refactor for css that does not make sense (duplicate class), making components for the displayed schedule, fixing highlighting for selection in my-group.

Related Issue

Closes #37

Type of change

New feature / Refactor

Testing

• I added/updated tests.
• I tested my changes locally.
  • I tested my changes with a laptop-size screen.
  • I tested my changes with a phone-size screen.
  • I tested my changes with a tablet-size screen.
• I tested on the kennel preview deployment for this pull request.

Screenshots/Recordings

Checklist

• My code follows the project's existing style.
• I have reviewed my changes.
• Only the necessary files and lines have been changed.
• This PR is ready for review.

## Description add loading skeleton into the feed/my-group pages by adding "loading" variable to data fetching hook. This pr also come with some refactor for css that does not make sense (duplicate class), making components for the displayed schedule, fixing highlighting for selection in my-group. ## Related Issue <!-- Link the issue this PR addresses, if applicable. --> Closes #37 ## Type of change New feature / Refactor ## Testing - [x] I added/updated tests. - [x] I tested my changes locally. - [x] I tested my changes with a laptop-size screen. - [x] I tested my changes with a phone-size screen. - [x] I tested my changes with a tablet-size screen. - [ ] I tested on the kennel preview deployment for this pull request. ## Screenshots/Recordings <!-- If this includes a UI change, attach screenshots on both laptop and mobile. --> ## Checklist - [x] My code follows the project's existing style. - [x] I have reviewed my changes. - [x] Only the necessary files and lines have been changed. - [x] This PR is ready for review.

Screenshot 2026-10-25 001551.png

51 KiB

Screenshot 2026-10-25 000958.png

58 KiB

klaipras added 8 commits 2026-10-25 04:13:57 +00:00

init 0fba56f551

Merge branch 'remove-light-dark-props' of ssh://git.cmu.dev/ScottyLabs/study into loading-skeleton d87dd46e9d

feat: fake loading skeleton 7478481ae3

Merge branch 'ui_change' of ssh://git.cmu.dev/ScottyLabs/study into loading-skeleton 644ac5b4ae

fix: no course found height match regular d07c9aaa19

Merge branch 'ui_change' of ssh://git.cmu.dev/ScottyLabs/study into loading-skeleton dd89021576

feat: add loading functionality to group hook 23444e066a

feat: add loading skeleton 144ae50355

scottylabs-bot commented 2026-10-25 04:15:23 +00:00

Owner

Copy link

Kennel Deployments

Service	URL
web	https://study-web-pr-83.scottylabs.net

Last updated for commit cf6636b.

<!-- kennel-deployment --> ### Kennel Deployments | Service | URL | | --- | --- | | web | https://study-web-pr-83.scottylabs.net | Last updated for commit `cf6636b`.

klaipras added 1 commit 2026-10-25 04:15:46 +00:00

feat: little color readjust for light theme 3be0184abd

klaipras commented 2026-10-25 04:15:56 +00:00

Author

Member

Copy link

No description provided.

Screenshot 2026-10-25 000958.png

58 KiB

Screenshot 2026-10-25 001551.png

51 KiB

klaipras added 1 commit 2026-10-25 04:23:55 +00:00

fix: no group found text message e3fbf0978e

klaipras added 2 commits 2026-10-25 04:28:16 +00:00

fix: placeholderlength 0ec2a9bcf3

Merge branch 'ui_change' of ssh://git.cmu.dev/ScottyLabs/study into loading-skeleton 414e4c59ee

klaipras added 3 commits 2026-10-25 04:50:31 +00:00

Merge branch 'ui_change' of ssh://git.cmu.dev/ScottyLabs/study into loading-skeleton a077b11b9b

fix: resolving merge conflict 2bf2fbad86

Merge branch 'loading-skeleton' of ssh://git.cmu.dev/ScottyLabs/study into loading-skeleton d7f18d4581

klaipras requested reviews from annadavi, mishag, cseluzhy 2026-10-25 04:54:50 +00:00

klaipras added 1 commit 2026-10-26 02:56:08 +00:00

Merge branch 'ui_change' of ssh://git.cmu.dev/ScottyLabs/study into loading-skeleton 252be29c93

klaipras added 2 commits 2026-10-26 03:07:37 +00:00

feat: skeleton for group sharing f152019b82

Merge branch 'ui_change' into loading-skeleton 0b9644e2f7

klaipras added 2 commits 2026-10-26 03:30:12 +00:00

fix: app empty correct height e22cde5e26

Merge branch 'ui_change' into loading-skeleton b68c44c1a5

klaipras added 1 commit 2026-10-31 20:18:21 +00:00

Merge branch 'ui_change' into loading-skeleton 48e14ebeda

klaipras added 10 commits 2026-10-31 20:30:42 +00:00

init 5ec49f803d

feat: fake loading skeleton beb7c215b7

fix: no course found height match regular 47b204c4ac

feat: add loading functionality to group hook bdc269b50f

feat: add loading skeleton dbf3d9d8f3

feat: little color readjust for light theme f3423db369

fix: placeholderlength 08054adc38

fix: resolving merge conflict dcfabf9b37

feat: skeleton for group sharing 04c3f95f4e

Merge branch 'loading-skeleton' of ssh://git.cmu.dev/ScottyLabs/study into loading-skeleton b475efa94e

klaipras force-pushed loading-skeleton from b475efa94e to b68c44c1a5 2026-10-31 20:53:57 +00:00 Compare

klaipras added 1 commit 2026-10-31 20:57:42 +00:00

Merge branch 'ui_change' into loading-skeleton cf6636b68d

All checks were successful

Hide checks

nixbot/nix-eval evaluation succeeded in 0s (1 warning)

Details

nixbot/nix-build 0 attributes built

Details

kennel/build build succeeded

Required

Details

kennel/deploy deployment healthy

Required

Details

Test / Unit tests (pull_request) Successful in 1m21s

Required

Details

Test / Integration tests (pull_request) Successful in 2m32s

Required

Details

This pull request doesn't have enough approvals yet. 0 of 1 approvals granted.

You are not authorized to merge this pull request.

View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.

git fetch -u origin loading-skeleton:loading-skeleton

git switch loading-skeleton

Sign in to join this conversation.

Reviewers

No reviewers

cseluzhy

annadavi

mishag

Labels

Clear labels   

first-task

  

needs/docs

Must have documentation written

  

needs/research

Discuss the ideal implementation with the tech lead

  

needs/upstream

Needs a contribution to an upstream project

  

type/bug

Something not working as intended

  

type/external

Lives outside of code

  

type/feature

New functionality

  

type/refactor

Improving existing code

  

urgency

high

This is currently causing issues

  

urgency

immediate

This is making a project or feature unusable

  

urgency

low

This can happen whenever

  

urgency

medium

This is expected to cause issues soon

No labels

first-task

needs/docs

needs/research

needs/upstream

type/bug

type/external

type/feature

type/refactor

urgency

high

urgency

immediate

urgency

low

urgency

medium

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

ScottyLabs/study!83

No description provided.