feat: order home recommendations from survey answers #86

Closed

ManrajS wants to merge 2 commits from feat/home-page-recommendations into main

pull from: feat/home-page-recommendations

merge into: ScottyLabs:main

ScottyLabs:main

ScottyLabs:fix/vite-config-windows-path

ScottyLabs:fix/comparison-apartment-room-types

ScottyLabs:renovate/scottylabs-devenv-digest

ScottyLabs:feat/home-recommendations

ScottyLabs:openbao-update

ScottyLabs:profile-page

ScottyLabs:renovate/lock-file-maintenance

ScottyLabs:survey-link

ScottyLabs:auth

ScottyLabs:update

ScottyLabs:update-devenv

ScottyLabs:fix-devenv

ScottyLabs:fix-spa-fallback

ScottyLabs:building-comparison

ScottyLabs:setup-database-schema

ScottyLabs:add-floor-plan-gallery

Conversation 2 Commits 2 Files changed 8 +110 -21

ManrajS commented 2026-08-08 00:21:29 +00:00 (Migrated from codeberg.org)

Copy link

home page recommendations were 5 hardcoded ids in BuildingPanelDemo. now it loads the saved
survey answers and ranks buildings with the scoring from #15, falls back to alphabetical if
there's no survey or youre logged out.

also noticed the filters in building options were resetting whenever you navigated away so i
did a quick fix for that too.

closes #55

home page recommendations were 5 hardcoded ids in BuildingPanelDemo. now it loads the saved survey answers and ranks buildings with the scoring from #15, falls back to alphabetical if there's no survey or youre logged out. also noticed the filters in building options were resetting whenever you navigated away so i did a quick fix for that too. closes #55

gostmeaper requested reviews from emmawong, NikhilR 2026-09-10 17:49:37 +00:00

gostmeaper requested review from gostmeaper 2026-09-13 18:59:38 +00:00

gostmeaper force-pushed feat/home-page-recommendations from d394c4ecef to 9c4b7d5133 2026-09-13 21:41:36 +00:00 Compare

gostmeaper requested changes 2026-09-17 16:28:01 +00:00

gostmeaper left a comment

Copy link

Additionally...

• this pr needs a rebase
• fix the oxlint errors

Additionally... - this pr needs a rebase - fix the oxlint errors

emmawong requested changes 2026-09-17 18:11:47 +00:00

emmawong left a comment

Copy link

Hi, nice work! There is an issue here though:

Gender restrictions are currently treated as a scoring bonus rather than an eligibility rule. scoreBuilding() adds one point for an exact gender-housing match, but it never removes incompatible buildings. So to demonstrate the issue, if a male user selects AC and a single room, they'll receive Scobell(which is women-only) among their recs.

My suggested approach is to have a hard filter included, so that if a person were to choose women only, they would only get women-only buildings, or if a person chose male only, they would get men only buildings(while this does not exist as of now, it is good practice to keep it. In the frontend, we can make changes so that it doesn't show for now, but if a house/dorm ever appears we can reopen this issue and take a look at that).

Best,
Emma

Hi, nice work! There is an issue here though: Gender restrictions are currently treated as a scoring bonus rather than an eligibility rule. scoreBuilding() adds one point for an exact gender-housing match, but it never removes incompatible buildings. So to demonstrate the issue, if a male user selects AC and a single room, they'll receive Scobell(which is women-only) among their recs. My suggested approach is to have a hard filter included, so that if a person were to choose women only, they would only get women-only buildings, or if a person chose male only, they would get men only buildings(while this does not exist as of now, it is good practice to keep it. In the frontend, we can make changes so that it doesn't show for now, but if a house/dorm ever appears we can reopen this issue and take a look at that). Best, Emma

emmawong referenced this pull request 2026-09-18 06:02:46 +00:00

Build an gender-eligibility filter for recommendations #95

emmawong referenced this pull request 2026-09-18 06:20:58 +00:00

Finish survey-based Home recommendations #96

anish force-pushed feat/home-page-recommendations from 9c4b7d5133 to 4072a5963e 2026-09-23 00:18:04 +00:00 Compare

gostmeaper added the

size/M

label 2026-09-23 00:31:42 +00:00

manrajs closed this pull request 2026-09-30 20:25:52 +00:00

manrajs referenced this pull request 2026-09-30 21:06:22 +00:00

feat: order home recommendations from survey answers #107

Some checks failed

Hide checks

kennel/build build succeeded

Details

PR size / size (pull_request) Successful in 4s

Details

PR title / lint (pull_request) Successful in 0s

Details

kennel/deploy provisioning declared resource 'postgres' failed: psql failed [GRANT CREATE ON DATABASE "kennel_019eaa84_574f_7af2_965e_4f872de9e728_pr_86" TO "kennel_019eaa84_574f_7af2_965e_4f872de9e728_pr_86_owner"]: ERROR: database "kennel_019eaa84_574f_7af2_965e_4f872de9e728_pr_86" does not exist

Details

CI / check-openapi (pull_request) Failing after 35s

Details

CI / check-1 (pull_request) Failing after 35s

Details

CI / build (pull_request) Failing after 39s

Details

CI / check (pull_request) Failing after 0s

Details

Pull request closed

Please reopen this pull request to perform a merge.

Sign in to join this conversation.

Reviewers

No reviewers

NikhilR

gostmeaper

emmawong

Labels

Clear labels   

backend

apps/backend

  

beginner friendly

Good first issue for a new member

  

bug

Something isn't working

  

chore

Maintenance, tooling, dependencies

  

documentation

Docs and READMEs

  

enhancement

New feature or request

  

frontend

apps/frontend

  

needs-triage

Not yet sized, prioritised or staged

  

no-stale

Exempt from the stale nudge

  

priority/high

Blocking or time-sensitive

  

priority/low

Nice to have

  

priority/medium

Normal priority

  

size/L

Under 600 changed lines

  

size/M

Under 200 changed lines

  

size/S

Under 50 changed lines

  

size/XL

600+ changed lines - consider splitting it

  

size/XS

Under 10 changed lines

  

stage/backlog

Parked on purpose - not up for grabs yet

  

stage/done

Closed

  

stage/in progress

Issue is in progress

  

stage/in-progress

Someone is assigned and working on it

  

stage/ready

Unassigned and ready for someone to pick up

  

stale

No activity for a while - applied by stale.yml

  

wontfix

This will not be worked on

  

needs/docs

Must have documentation written

  

needs/research

Discuss the ideal implementation with the tech lead

  

needs/upstream

Needs a contribution to an upstream project

  

type/bug

Something not working as intended

  

type/external

Lives outside of code

  

type/feature

New functionality

  

type/refactor

Improving existing code

  

urgency

high

This is currently causing issues

  

urgency

immediate

This is making a project or feature unusable

  

urgency

low

This can happen whenever

  

urgency

medium

This is expected to cause issues soon

No labels

backend

beginner friendly

bug

chore

documentation

enhancement

frontend

needs-triage

no-stale

priority/high

priority/low

priority/medium

size/L

size/M

size/S

size/XL

size/XS

stage/backlog

stage/done

stage/in progress

stage/in-progress

stage/ready

stale

wontfix

needs/docs

needs/research

needs/upstream

type/bug

type/external

type/feature

type/refactor

urgency

high

urgency

immediate

urgency

low

urgency

medium

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

4 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

ScottyLabs/housing!86

No description provided.