rhsen/housing
Watch
1
0
Fork
You've already forked housing
 0
forked from ScottyLabs/housing
Code Pull requests 1 Activity

feat: upperclassmen data (#104) #1

Open
rhsen wants to merge 2 commits from ScottyLabs/housing:main into main
pull from: ScottyLabs/housing:main
merge into: rhsen:main
Conversation 0 Commits 2 Files changed 1 +1 -1
rhsen commented 2026-10-01 17:55:37 +00:00
Owner
Copy link

Added upperclassmen data taking note of a few things:

  • Spirit House is offline until further notice so we'll want to show that somehow
  • I didn't add walkthrough links since for the apartment style ones like fairfax there is more walkthroughs than floorplans for each type of room, so we'll need to add it later when we figure out how to store and display it.
  • We should prob note that like some of the data especially upperclassmen aren't up to date. Ex. Fairfax has no pictures.

Co-authored-by: Ryan Li ryanli1366@gmail.com
Reviewed-on: ScottyLabs/housing#104

Added upperclassmen data taking note of a few things: - Spirit House is offline until further notice so we'll want to show that somehow - I didn't add walkthrough links since for the apartment style ones like fairfax there is more walkthroughs than floorplans for each type of room, so we'll need to add it later when we figure out how to store and display it. - We should prob note that like some of the data especially upperclassmen aren't up to date. Ex. Fairfax has no pictures. Co-authored-by: Ryan Li <ryanli1366@gmail.com> Reviewed-on: https://git.cmu.dev/ScottyLabs/housing/pulls/104
Added upperclassmen data taking note of a few things:
- Spirit House is offline until further notice so we'll want to show that somehow
- I didn't add walkthrough links since for the apartment style ones like fairfax there is more walkthroughs than floorplans for each type of room, so we'll need to add it later when we figure out how to store and display it.
- We should prob note that like some of the data especially upperclassmen aren't up to date. Ex. Fairfax has no pictures.

Co-authored-by: Ryan Li <ryanli1366@gmail.com>
Reviewed-on: ScottyLabs/housing#104
Reviewed-on: ScottyLabs/housing#108
This pull request can be merged automatically.
This branch is out-of-date with the base branch
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u main:ScottyLabs-main
git switch ScottyLabs-main

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch main
git merge --no-ff ScottyLabs-main
git switch ScottyLabs-main
git rebase main
git switch main
git merge --ff-only ScottyLabs-main
git switch ScottyLabs-main
git rebase main
git switch main
git merge --no-ff ScottyLabs-main
git switch main
git merge --squash ScottyLabs-main
git switch main
git merge --ff-only ScottyLabs-main
git switch main
git merge ScottyLabs-main
git push origin main
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
rhsen/housing!1
No description provided.