feat: upperclassmen data (#104) #1

Open
rhsen wants to merge 2 commits from ScottyLabs/housing:main into main
Owner

Added upperclassmen data taking note of a few things:

  • Spirit House is offline until further notice so we'll want to show that somehow
  • I didn't add walkthrough links since for the apartment style ones like fairfax there is more walkthroughs than floorplans for each type of room, so we'll need to add it later when we figure out how to store and display it.
  • We should prob note that like some of the data especially upperclassmen aren't up to date. Ex. Fairfax has no pictures.

Co-authored-by: Ryan Li ryanli1366@gmail.com
Reviewed-on: ScottyLabs/housing#104

Added upperclassmen data taking note of a few things: - Spirit House is offline until further notice so we'll want to show that somehow - I didn't add walkthrough links since for the apartment style ones like fairfax there is more walkthroughs than floorplans for each type of room, so we'll need to add it later when we figure out how to store and display it. - We should prob note that like some of the data especially upperclassmen aren't up to date. Ex. Fairfax has no pictures. Co-authored-by: Ryan Li <ryanli1366@gmail.com> Reviewed-on: https://git.cmu.dev/ScottyLabs/housing/pulls/104
Added upperclassmen data taking note of a few things:
- Spirit House is offline until further notice so we'll want to show that somehow
- I didn't add walkthrough links since for the apartment style ones like fairfax there is more walkthroughs than floorplans for each type of room, so we'll need to add it later when we figure out how to store and display it.
- We should prob note that like some of the data especially upperclassmen aren't up to date. Ex. Fairfax has no pictures.

Co-authored-by: Ryan Li <ryanli1366@gmail.com>
Reviewed-on: ScottyLabs/housing#104
Signed-off-by: Anish Pallati <i@anish.land>
This will fix our open api check fail.

Reviewed-on: ScottyLabs/housing#121
takes on #101

Co-authored-by: Rohan <83433649+RohanSen08@users.noreply.github.com>
Co-authored-by: NikhilR <nramanuj@andrew.cmu.edu>
Co-authored-by: ManrajS <manrajs@noreply.codeberg.org>
Co-authored-by: Loc Ho <lxh@andrew.cmu.edu>
Co-authored-by: Anish Pallati <i@anish.land>
Co-authored-by: locho7 <lxh@andrew.cmu.edu>
Co-authored-by: Rohan Sen <rhsen@andrew.cmu.edu>
Reviewed-on: ScottyLabs/housing#115
Reviewed-by: Nikhil Ramanuja <nramanuj@andrew.cmu.edu>
Co-authored-by: Zoe Xue <k2109421@students.katyisd.org>
Reviewed-on: ScottyLabs/housing#129
Reviewed-by: Nikhil Ramanuja <nramanuj@andrew.cmu.edu>
replaced #86, fixed the comments on 86 and added the gender filter rule based on pr 55

closes #55

Co-authored-by: ManrajS <manrajs@noreply.codeberg.org>
Reviewed-on: ScottyLabs/housing#107
Reviewed-by: Nikhil Ramanuja <nramanuj@andrew.cmu.edu>
Co-authored-by: Gostmeaper <johnchangcao@gmail.com>
Reviewed-on: ScottyLabs/housing#131
Signed-off-by: Anish Pallati <i@anish.land>
Signed-off-by: Anish Pallati <i@anish.land>
Signed-off-by: Anish Pallati <i@anish.land>
Signed-off-by: Anish Pallati <i@anish.land>
closes #30

Co-authored-by: locho7 <lxh@andrew.cmu.edu>
Co-authored-by: Gostmeaper <johnchangcao@gmail.com>
Reviewed-on: ScottyLabs/housing#128
Bugs addressed:
- Not all majors being displayed
- Data missing some location information
- Data having informal data / descriptions
- Navbar being oddly spaced
- missing home tab from design
- startup survey too large for screen
- home page too large for screen
- missing browser icon
- missing autofill for majors
- all building details don't fit on page
- building filter is too large for page compared to design

Reviewed-on: ScottyLabs/housing#135
Signed-off-by: Anish Pallati <i@anish.land>
Fixes a number of smaller bugs:
- Logo goes to startup instead of home
- Profile no long 404s and has a temp dropdown menu
- new heading on startup
- more filters with collapsability.

Reviewed-on: ScottyLabs/housing#142
- Autosave each survey change (debounced) and show save status
- Send signed-in users from the launch page to /home
- After login, go to /home instead of /survey if preferences exist
- Add StatusMessage and use it for the review form error and share copy feedback
- Add enSuiteKitchen filter, scored from amenities.kitchen.scope
  - Map the survey "En suite kitchen" answer to it
  - Add the checkbox to the filter menu

Co-authored-by: Gostmeaper <johnchangcao@gmail.com>
Reviewed-on: ScottyLabs/housing#141
Co-authored-by: Zoe Xue <k2109421@students.katyisd.org>
Co-authored-by: Gostmeaper <johnchangcao@gmail.com>
Reviewed-on: ScottyLabs/housing#149
This pull request can be merged automatically.
This branch is out-of-date with the base branch
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u 'main:ScottyLabs-main'
git switch 'ScottyLabs-main'

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch 'main'
git merge --no-ff 'ScottyLabs-main'
git switch 'ScottyLabs-main'
git rebase 'main'
git switch 'main'
git merge --ff-only 'ScottyLabs-main'
git switch 'ScottyLabs-main'
git rebase 'main'
git switch 'main'
git merge --no-ff 'ScottyLabs-main'
git switch 'main'
git merge --squash 'ScottyLabs-main'
git switch 'main'
git merge --ff-only 'ScottyLabs-main'
git switch 'main'
git merge 'ScottyLabs-main'
git push origin 'main'
Sign in to join this conversation.
No reviewers
No labels
No milestone
No assignees
5 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
rhsen/housing!1
No description provided.