ScottyLabs/study
Watch
16
0
Fork
You've already forked study
 1
Code Issues 34 Pull requests 3 Projects 1 Releases Packages Wiki Activity Actions

feat: use nextjs link tag instead of a #85

Merged
annadavi merged 9 commits from link-tag-nextjs into ui_change 2026-10-27 19:39:25 +00:00
Conversation 5 Commits 9 Files changed 7 +46 -26
klaipras commented 2026-10-25 18:18:37 +00:00
Member
Copy link

Using nextjs built-in link element instead of normal tag use the client side navigation which make the experience smoother along with having faster load time

Related Issue

Closes #84

Type of change

New feature

Testing

  • I added/updated tests.
  • I tested my changes locally.
    • I tested my changes with a laptop-size screen.
    • I tested my changes with a phone-size screen.
    • I tested my changes with a tablet-size screen.
  • I tested on the kennel preview deployment for this pull request.

Screenshots/Recordings

Checklist

  • My code follows the project's existing style.
  • I have reviewed my changes.
  • Only the necessary files and lines have been changed.
  • This PR is ready for review.
Using nextjs built-in link element instead of normal <a> tag use the client side navigation which make the experience smoother along with having faster load time ## Related Issue Closes #84 ## Type of change New feature ## Testing - [x] I added/updated tests. - [x] I tested my changes locally. - [x] I tested my changes with a laptop-size screen. - [x] I tested my changes with a phone-size screen. - [x] I tested my changes with a tablet-size screen. - [x] I tested on the kennel preview deployment for this pull request. ## Screenshots/Recordings <!-- If this includes a UI change, attach screenshots on both laptop and mobile. --> ## Checklist - [x] My code follows the project's existing style. - [x] I have reviewed my changes. - [x] Only the necessary files and lines have been changed. - [x] This PR is ready for review.
feat: use nextjs link tag instead of a
All checks were successful
Test / Integration tests (pull_request) Successful in 2m2s
Details
nixbot/nix-eval evaluation succeeded in 0s (1 warning)
Details
nixbot/nix-build 0 attributes built
Details
Test / Unit tests (pull_request) Successful in 33s
Details
kennel/build build succeeded
Details
kennel/deploy deployment healthy
Details
7d54b7c143
scottylabs-bot commented 2026-10-25 18:20:04 +00:00
Owner
Copy link

Kennel Deployments

Torn down at 2026-10-27 19:39:26 UTC.

<!-- kennel-deployment --> ### Kennel Deployments Torn down at 2026-10-27 19:39:26 UTC.
feat: force drawer close on mobile nav
All checks were successful
kennel/build build succeeded
Details
kennel/deploy deployment healthy
Details
nixbot/nix-eval evaluation succeeded in 0s (1 warning)
Details
nixbot/nix-build 0 attributes built
Details
Test / Unit tests (pull_request) Successful in 31s
Details
Test / Integration tests (pull_request) Successful in 1m58s
Details
5b70a44d07
Merge branch 'ui_change' of ssh://git.cmu.dev/ScottyLabs/study into link-tag-nextjs
All checks were successful
kennel/build build succeeded
Details
nixbot/nix-eval evaluation succeeded in 0s (1 warning)
Details
nixbot/nix-build 0 attributes built
Details
Test / Unit tests (pull_request) Successful in 32s
Details
kennel/deploy deployment healthy
Details
Test / Integration tests (pull_request) Successful in 1m58s
Details
77193c59a7
Merge branch 'link-tag-nextjs' of ssh://git.cmu.dev/ScottyLabs/study into link-tag-nextjs
All checks were successful
nixbot/nix-eval evaluation succeeded in 0s (1 warning)
Details
kennel/build build succeeded
Details
kennel/deploy deployment healthy
Details
nixbot/nix-build 0 attributes built
Details
Test / Unit tests (pull_request) Successful in 1m16s
Details
Test / Integration tests (pull_request) Successful in 2m15s
Details
a503a096c1
Merge branch 'ui_change' into link-tag-nextjs
All checks were successful
kennel/build build succeeded
Details
kennel/deploy deployment healthy
Details
nixbot/nix-eval evaluation succeeded in 0s (1 warning)
Details
nixbot/nix-build 0 attributes built
Details
Test / Integration tests (pull_request) Successful in 2m16s
Details
Test / Unit tests (pull_request) Successful in 1m19s
Details
63dcbd7f0e
Merge branch 'ui_change' into link-tag-nextjs
All checks were successful
kennel/deploy deployment healthy
Details
nixbot/nix-eval evaluation succeeded in 0s (1 warning)
Details
nixbot/nix-build 0 attributes built
Details
kennel/build build succeeded
Details
Test / Integration tests (pull_request) Successful in 2m14s
Details
Test / Unit tests (pull_request) Successful in 1m19s
Details
8d51667be3
annadavi approved these changes 2026-10-26 03:24:16 +00:00
Dismissed
annadavi dismissed annadavi's review 2026-10-26 03:27:47 +00:00
annadavi requested changes 2026-10-26 03:35:00 +00:00
Dismissed
annadavi left a comment
Copy link

There are a few external links that shouldn't use the Link element since it is meant for internal links. I commented on each location. Just revert to whatever it used before (a or href) for those. All the internal links are fine.

There are a few external links that shouldn't use the Link element since it is meant for internal links. I commented on each location. Just revert to whatever it used before (a or href) for those. All the internal links are fine.
src/app/access-restricted/page.tsx Outdated
@ -57,12 +58,12 @@ export default function AccessRestrictedPage() {
{/* Subtle footer note */}
<div className="mt-12 text-sm text-black opacity-70 dark:text-white">
If you believe you reached this page in error, please contact{" "}
<a
annadavi commented 2026-10-26 03:29:15 +00:00
Member
Copy link

This is an external link, so shouldn't use Link.

This is an external link, so shouldn't use Link.
src/app/eligibility-unavailable/page.tsx Outdated
@ -32,12 +33,12 @@ export default function EligibilityUnavailablePage() {
<div className="mt-12 text-sm text-black opacity-70 dark:text-white">
If this continues, please contact{" "}
<a
annadavi commented 2026-10-26 03:30:27 +00:00
Member
Copy link

This (mailto) is an external link, so shouldn't use Link.

This (mailto) is an external link, so shouldn't use Link.
src/app/privacy/page.tsx Outdated
@ -184,3 +185,3 @@
You can revoke the app&apos;s access to your Google Account at any
time via your{" "}
<a
<Link
annadavi commented 2026-10-26 03:31:13 +00:00
Member
Copy link

This is an external link, so shouldn't use Link.

This is an external link, so shouldn't use Link.
src/components/layout/MobileNavBar.tsx Outdated
@ -104,2 +116,2 @@
</a>
<a
</Link>
<Link
annadavi commented 2026-10-26 03:31:51 +00:00
Member
Copy link

This is an external link, so shouldn't use Link.

This is an external link, so shouldn't use Link.
src/components/layout/NavBar.tsx Outdated
@ -73,3 +73,3 @@
<div className="sidebar-bottom">
<nav className="sidebar-utilities" aria-label="Utility navigation">
<a
<Link
annadavi commented 2026-10-26 03:32:27 +00:00
Member
Copy link

This is an external link, so shouldn't use Link.

This is an external link, so shouldn't use Link.
Revert "feat: use nextjs link tag instead of a"
All checks were successful
nixbot/nix-eval evaluation succeeded in 0s (1 warning)
Details
nixbot/nix-build 0 attributes built
Details
kennel/build build succeeded
Details
kennel/deploy deployment healthy
Details
Test / Unit tests (pull_request) Successful in 1m19s
Details
Test / Integration tests (pull_request) Successful in 2m15s
Details
dc397d16da 
This reverts commit 7d54b7c143.

fix: external link changed to <a>
klaipras commented 2026-10-26 03:45:19 +00:00
Author
Member
Copy link

Fixed

Fixed
fix: one more page
Some checks failed
nixbot/nix-eval evaluation failed
Details
nixbot/nix-build merge conflict
Details
kennel/build build succeeded
Details
kennel/deploy deployment healthy
Details
Test / Unit tests (pull_request) Successful in 1m47s
Details
Test / Integration tests (pull_request) Successful in 2m40s
Details
2681b0135e
annadavi approved these changes 2026-10-27 14:58:45 +00:00
annadavi merged commit 2681b0135e into ui_change 2026-10-27 19:39:25 +00:00
annadavi deleted branch link-tag-nextjs 2026-10-27 19:39:25 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
mishag
cseluzhy
annadavi
Labels
Clear labels   
first-task
  
needs/docs
Must have documentation written

  
needs/research
Discuss the ideal implementation with the tech lead

  
needs/upstream
Needs a contribution to an upstream project

  
type/bug
Something not working as intended

  
type/external
Lives outside of code

  
type/feature
New functionality

  
type/refactor
Improving existing code

  
urgency
high
 This is currently causing issues

  
urgency
immediate
 This is making a project or feature unusable

  
urgency
low
 This can happen whenever

  
urgency
medium
 This is expected to cause issues soon

No labels
first-task
needs/docs
needs/research
needs/upstream
type/bug
type/external
type/feature
type/refactor
urgency
high
urgency
immediate
urgency
low
urgency
medium
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
ScottyLabs/study!85
No description provided.