ScottyLabs/study
Watch
16
0
Fork
You've already forked study
 1
Code Issues 34 Pull requests 3 Projects 1 Releases Packages Wiki Activity Actions

issue-42-unblock-user-button-style #78

Open
bxiang wants to merge 3 commits from issue-42-unblock-user-button-style into ui_change
pull from: issue-42-unblock-user-button-style
merge into: ScottyLabs:ui_change
Conversation 2 Commits 3 Files changed 2 +36 -1
bxiang commented 2026-10-24 21:10:18 +00:00
Member
Copy link

Description

Updates the Unblock button to match the destructive action styling used elsewhere in the UI.

The button now uses the existing red light/dark mode color tokens and no longer has a border. I also added a test to verify the color tokens and border styling.

Related Issue

Closes #42

Type of change

Type: Bug fix / Test coverage

Testing

  • [x ] I added/updated tests.
  • [ x] I tested my changes locally.
    • [x ] I tested my changes with a laptop-size screen.
    • I tested my changes with a phone-size screen.
    • I tested my changes with a tablet-size screen.
  • I tested on the kennel preview deployment for this pull request.

Screenshots/Recordings

Checklist

  • [x ] My code follows the project's existing style.
  • [ x] I have reviewed my changes.
  • [ x] Only the necessary files and lines have been changed.
  • [ x] This PR is ready for review.
## Description Updates the Unblock button to match the destructive action styling used elsewhere in the UI. The button now uses the existing red light/dark mode color tokens and no longer has a border. I also added a test to verify the color tokens and border styling. ## Related Issue <!-- Link the issue this PR addresses, if applicable. --> Closes #42 ## Type of change **Type:** Bug fix / Test coverage ## Testing - [x ] I added/updated tests. - [ x] I tested my changes locally. - [x ] I tested my changes with a laptop-size screen. - [ ] I tested my changes with a phone-size screen. - [ ] I tested my changes with a tablet-size screen. - [ ] I tested on the kennel preview deployment for this pull request. ## Screenshots/Recordings <!-- If this includes a UI change, attach screenshots on both laptop and mobile. --> ## Checklist - [x ] My code follows the project's existing style. - [ x] I have reviewed my changes. - [ x] Only the necessary files and lines have been changed. - [ x] This PR is ready for review.
Screenshot 2026-10-03 at 5.40.19 PM.png
76 KiB
Screenshot 2026-10-03 at 5.40.24 PM.png
79 KiB
Screenshot 2026-10-03 at 5.40.19 PM.png Screenshot 2026-10-03 at 5.40.24 PM.png
test: verify unblock button styling
All checks were successful
nixbot/nix-eval evaluation succeeded in 0s (1 warning)
Details
nixbot/nix-build 0 attributes built
Details
kennel/build build succeeded
Details
kennel/deploy deployment healthy
Details
Test / Unit tests (pull_request) Successful in 1m31s
Details
Test / Integration tests (pull_request) Successful in 2m58s
Details
68d21e5ce3
scottylabs-bot commented 2026-10-24 21:11:28 +00:00
Owner
Copy link

Kennel Deployments

Service URL
web https://study-web-pr-78.scottylabs.net

Last updated for commit 68d21e5.

<!-- kennel-deployment --> ### Kennel Deployments | Service | URL | | --- | --- | | web | https://study-web-pr-78.scottylabs.net | Last updated for commit `68d21e5`.
annadavi commented 2026-11-02 00:53:22 +00:00
Member
Copy link

Can you add a space between the icon and the minus?

Can you add a space between the icon and the minus?
All checks were successful
nixbot/nix-eval evaluation succeeded in 0s (1 warning)
Details
nixbot/nix-build 0 attributes built
Details
kennel/build build succeeded
Required
Details
kennel/deploy deployment healthy
Required
Details
Test / Unit tests (pull_request) Successful in 1m31s
Required
Details
Test / Integration tests (pull_request) Successful in 2m58s
Required
Details
This pull request has changes conflicting with the target branch.
  • src/styles/components.css
View command line instructions

Manual merge helper

Use this merge commit message when completing the merge manually.

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin issue-42-unblock-user-button-style:issue-42-unblock-user-button-style
git switch issue-42-unblock-user-button-style
Sign in to join this conversation.
Reviewers
No reviewers
cseluzhy
mishag
annadavi
Labels
Clear labels   
first-task
  
needs/docs
Must have documentation written

  
needs/research
Discuss the ideal implementation with the tech lead

  
needs/upstream
Needs a contribution to an upstream project

  
type/bug
Something not working as intended

  
type/external
Lives outside of code

  
type/feature
New functionality

  
type/refactor
Improving existing code

  
urgency
high
 This is currently causing issues

  
urgency
immediate
 This is making a project or feature unusable

  
urgency
low
 This can happen whenever

  
urgency
medium
 This is expected to cause issues soon

No labels
first-task
needs/docs
needs/research
needs/upstream
type/bug
type/external
type/feature
type/refactor
urgency
high
urgency
immediate
urgency
low
urgency
medium
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
ScottyLabs/study!78
No description provided.