ScottyLabs/study
Watch
16
0
Fork
You've already forked study
 1
Code Issues 34 Pull requests 3 Projects 1 Releases Packages Wiki Activity Actions

refactor: combine duplicate server session functions #77

Merged
annadavi merged 1 commit from server-session-dup into ui_change 2026-10-24 21:26:57 +00:00
Conversation 2 Commits 1 Files changed 1 +1 -11
annadavi commented 2026-10-24 21:08:07 +00:00
Member
Copy link

Description

Delete duplicate functions in server session

Related Issue

Closes #

Type of change

Type: Refactor

Testing

  • I added/updated tests.
  • I tested my changes locally.
    • I tested my changes with a laptop-size screen.
    • I tested my changes with a phone-size screen.
    • I tested my changes with a tablet-size screen.
  • I tested on the kennel preview deployment for this pull request.

Screenshots/Recordings

Checklist

  • My code follows the project's existing style.
  • I have reviewed my changes.
  • Only the necessary files and lines have been changed.
  • This PR is ready for review.
## Description <!-- Please provide a description of the issue, the changes you made to fix it, and why they work. It is expected that you understand why your changes work and if you do not understand why at least say as much so a maintainer knows how much to value the PR. No AI slop. --> Delete duplicate functions in server session ## Related Issue <!-- Link the issue this PR addresses, if applicable. --> Closes #<!-- Add your issue number here --> ## Type of change **Type:** Refactor <!-- Bug fix / New feature / Refactor / Test coverage / Documentation --> ## Testing - [ ] I added/updated tests. - [X] I tested my changes locally. - [ ] I tested my changes with a laptop-size screen. - [ ] I tested my changes with a phone-size screen. - [ ] I tested my changes with a tablet-size screen. - [X] I tested on the kennel preview deployment for this pull request. ## Screenshots/Recordings <!-- If this includes a UI change, attach screenshots on both laptop and mobile. --> ## Checklist - [X] My code follows the project's existing style. - [X] I have reviewed my changes. - [X] Only the necessary files and lines have been changed. - [X] This PR is ready for review.
refactor: combine duplicate server session functions
All checks were successful
nixbot/nix-eval evaluation succeeded in 0s (1 warning)
Details
nixbot/nix-build 0 attributes built
Details
kennel/build build succeeded
Details
kennel/deploy deployment healthy
Details
Test / Unit tests (pull_request) Successful in 1m35s
Details
Test / Integration tests (pull_request) Successful in 4m23s
Details
fee96dae61
scottylabs-bot commented 2026-10-24 21:09:17 +00:00
Owner
Copy link

Kennel Deployments

Torn down at 2026-10-24 21:26:59 UTC.

<!-- kennel-deployment --> ### Kennel Deployments Torn down at 2026-10-24 21:26:59 UTC.
cseluzhy approved these changes 2026-10-24 21:17:15 +00:00
annadavi merged commit fee96dae61 into ui_change 2026-10-24 21:26:57 +00:00
annadavi deleted branch server-session-dup 2026-10-24 21:26:58 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
cseluzhy
Labels
Clear labels   
first-task
  
needs/docs
Must have documentation written

  
needs/research
Discuss the ideal implementation with the tech lead

  
needs/upstream
Needs a contribution to an upstream project

  
type/bug
Something not working as intended

  
type/external
Lives outside of code

  
type/feature
New functionality

  
type/refactor
Improving existing code

  
urgency
high
 This is currently causing issues

  
urgency
immediate
 This is making a project or feature unusable

  
urgency
low
 This can happen whenever

  
urgency
medium
 This is expected to cause issues soon

No labels
first-task
needs/docs
needs/research
needs/upstream
type/bug
type/external
type/feature
type/refactor
urgency
high
urgency
immediate
urgency
low
urgency
medium
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
ScottyLabs/study!77
No description provided.