fix: remove edit profile button #60

Merged
annadavi merged 4 commits from issue-30-remove-edit-profile-button into ui_change 2026-10-26 02:54:17 +00:00
Member

Description

Removes the Edit Profile button from the Profile page because it no longer provides any functionality. I removed the button from ProfileHeader, along with the unused onEdit prop, edit handler, and related ref. I also added a test to verify that the Edit Profile button is no longer rendered.

(#30)

Closes # 30

Type of change

Type: Bug fix / Test coverage

Testing

  • I added/updated tests.
  • I tested my changes locally.
    • I tested my changes with a laptop-size screen.
    • I tested my changes with a phone-size screen.
    • I tested my changes with a tablet-size screen.
  • I tested on the kennel preview deployment for this pull request.

Screenshots/Recordings

Checklist

  • My code follows the project's existing style.
  • I have reviewed my changes.
  • Only the necessary files and lines have been changed.
  • This PR is ready for review.
## Description Removes the Edit Profile button from the Profile page because it no longer provides any functionality. I removed the button from `ProfileHeader`, along with the unused `onEdit` prop, edit handler, and related ref. I also added a test to verify that the Edit Profile button is no longer rendered. ## Related Issue (https://git.cmu.dev/ScottyLabs/study/issues/30) Closes # 30 ## Type of change **Type:** Bug fix / Test coverage ## Testing - [x] I added/updated tests. - [x] I tested my changes locally. - [x] I tested my changes with a laptop-size screen. - [x] I tested my changes with a phone-size screen. - [x] I tested my changes with a tablet-size screen. - [x] I tested on the kennel preview deployment for this pull request. ## Screenshots/Recordings <!-- If this includes a UI change, attach screenshots on both laptop and mobile. --> ## Checklist - [x] My code follows the project's existing style. - [x] I have reviewed my changes. - [x] Only the necessary files and lines have been changed. - [x] This PR is ready for review.
test: verify edit profile button is removed
All checks were successful
Deploy to Railway Dev / Deploy to Dev (push) Successful in 2m8s
kennel/build skipped: no services or static sites defined
Test / Unit and integration tests (push) Successful in 2m5s
Test / Unit and integration tests (pull_request) Successful in 2m0s
7e775f0ddf
bxiang changed title from issue-30-remove-edit-profile-button to fix: remove edit profile button 2026-10-03 21:03:41 +00:00
bxiang changed title from fix: remove edit profile button to fix: remove edit profile button #30 2026-10-03 21:04:04 +00:00
bxiang changed title from fix: remove edit profile button #30 to fix: remove edit profile button 2026-10-03 21:04:09 +00:00
Member

For future reference, you only need to put the issue number once, next to the existing "Closes #", but don't put a space between the "#" and the number. Also, make sure you have actually completed each check before marking the box (you couldn't have tested with kennel yet, so that can be left unchecked for now).

For future reference, you only need to put the issue number once, next to the existing "Closes #", but don't put a space between the "#" and the number. Also, make sure you have actually completed each check before marking the box (you couldn't have tested with kennel yet, so that can be left unchecked for now).
annadavi approved these changes 2026-10-04 02:58:31 +00:00
annadavi left a comment

Be sure to update your branch with merge or rebase from the base branch (dropdown below on the right) before creating the merge commit into ui_change!

Be sure to update your branch with merge or rebase from the base branch (dropdown below on the right) before creating the merge commit into ui_change!
sudipi scheduled this pull request to auto merge when all checks succeed 2026-10-24 20:51:17 +00:00
sudipi scheduled this pull request to auto merge when all checks succeed 2026-10-24 20:54:16 +00:00
bxiang canceled auto merging this pull request when all checks succeed 2026-10-24 21:13:26 +00:00
fix: merge ui_change into remove-edit-profile-button
All checks were successful
nixbot/nix-build 0 attributes built
kennel/build build succeeded
nixbot/nix-eval evaluation succeeded in 0s (1 warning)
kennel/deploy deployment healthy
Test / Unit tests (pull_request) Successful in 1m18s
Test / Integration tests (pull_request) Successful in 2m15s
6279e9a1ab

Kennel Deployments

Torn down at 2026-10-26 02:54:18 UTC.

<!-- kennel-deployment --> ### Kennel Deployments Torn down at 2026-10-26 02:54:18 UTC.
fix: repair broken ref from merge
All checks were successful
nixbot/nix-eval evaluation succeeded in 0s (1 warning)
nixbot/nix-build 0 attributes built
kennel/build build succeeded
kennel/deploy deployment healthy
Test / Unit tests (pull_request) Successful in 1m16s
Test / Integration tests (pull_request) Successful in 2m15s
45d9c4fd38
annadavi merged commit 45d9c4fd38 into ui_change 2026-10-26 02:54:17 +00:00
annadavi deleted branch issue-30-remove-edit-profile-button 2026-10-26 02:54:17 +00:00
Sign in to join this conversation.
No description provided.