ScottyLabs/study
Watch
16
0
Fork
You've already forked study
 1
Code Issues 34 Pull requests 3 Projects 1 Releases Packages Wiki Activity Actions

purposes_dropdown #58

Closed
andyj wants to merge 1 commit from purposes_dropdown into main
pull from: purposes_dropdown
merge into: ScottyLabs:main
Conversation 1 Commits 1 Files changed 1 +5103 -944
andyj commented 2026-10-03 20:24:05 +00:00
Member
Copy link

Description

changed the "purpose" field to a dropdown

Related Issue

Closes #29

Type of change

feature

Testing

  • I added/updated tests.
  • I tested my changes locally.
    • I tested my changes with a laptop-size screen.
    • I tested my changes with a phone-size screen.
    • I tested my changes with a tablet-size screen.
  • I tested on the kennel preview deployment for this pull request.

Screenshots/Recordings

Checklist

  • My code follows the project's existing style.
  • I have reviewed my changes.
  • Only the necessary files and lines have been changed.
  • This PR is ready for review.
## Description changed the "purpose" field to a dropdown ## Related Issue Closes #29 ## Type of change feature ## Testing - [x] I added/updated tests. - [x] I tested my changes locally. - [x] I tested my changes with a laptop-size screen. - [x] I tested my changes with a phone-size screen. - [x] I tested my changes with a tablet-size screen. - [ ] I tested on the kennel preview deployment for this pull request. ## Screenshots/Recordings <!-- If this includes a UI change, attach screenshots on both laptop and mobile. --> ## Checklist - [x] My code follows the project's existing style. - [x] I have reviewed my changes. - [x] Only the necessary files and lines have been changed. - [x] This PR is ready for review.
Screenshot 2026-10-03 at 4.20.52 PM.png
536 KiB
Screenshot 2026-10-03 at 4.20.52 PM.png
Merge branch 'main' into ui_change
All checks were successful
Deploy to Railway Dev / Deploy to Dev (push) Successful in 4m58s
Details
dfd668f3fa
add Vitest unit and integration tests for join group button
All checks were successful
Deploy to Railway Dev / Deploy to Dev (push) Successful in 3m4s
Details
88bab107e1
ci: add native NixOS test workflow
All checks were successful
Deploy to Railway Dev / Deploy to Dev (push) Successful in 2m14s
Details
Test / Unit and integration tests (push) Successful in 1m42s
Details
kennel/build skipped: no services or static sites defined
Details
Test / Unit and integration tests (pull_request) Successful in 1m41s
Details
b14f680ce0
Merge pull request 'Add tests for join-group button' (#26) from test-join into ui_change
Some checks failed
Deploy to Railway Dev / Deploy to Dev (push) Has been cancelled
Details
Test / Unit and integration tests (push) Successful in 2m4s
Details
5939becd56
 
Reviewed-on: #26
feat: added purpose dropdown
Some checks failed
Deploy to Railway Dev / Deploy to Dev (push) Has been cancelled
Details
Test / Unit and integration tests (push) Has been cancelled
Details
kennel/build skipped: no services or static sites defined
Details
Test / Unit and integration tests (pull_request) Successful in 4m15s
Details
540c210234
annadavi commented 2026-10-04 02:50:10 +00:00
Member
Copy link

Why is this PR huge??? I think your history got weird and is including commits that weren't yours. Take a look at your local branch and see, maybe a rebase or merge got messed up or you just need to rebase or merge with ui_change again. I'd recommend starting by fetching and pulling this branch as well as ui_change locally, then asking Codex or Claude to take a look at your git history to see where it went wrong, it can often figure out and fix problems like this pretty quickly. You will probably have to force push afterwards, which will automatically update this PR. Then verify that you only see your actual changes on here, which should be significantly less than 5000 lines. Reply to this once that's done so someone can review it.

Why is this PR huge??? I think your history got weird and is including commits that weren't yours. Take a look at your local branch and see, maybe a rebase or merge got messed up or you just need to rebase or merge with ui_change again. I'd recommend starting by fetching and pulling this branch as well as ui_change locally, then asking Codex or Claude to take a look at your git history to see where it went wrong, it can often figure out and fix problems like this pretty quickly. You will probably have to force push afterwards, which will automatically update this PR. Then verify that you only see your actual changes on here, which should be significantly less than 5000 lines. Reply to this once that's done so someone can review it.
andyj closed this pull request 2026-10-24 20:48:28 +00:00
Some checks are pending
Deploy to Railway Dev / Deploy to Dev (push) Has been cancelled
Details
Test / Unit and integration tests (push) Has been cancelled
Details
kennel/build skipped: no services or static sites defined
Required
Details
Test / Unit and integration tests (pull_request) Successful in 4m15s
Details
Test / Unit tests (pull_request)
Required
Test / Integration tests (pull_request)
Required
kennel/deploy
Required

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
first-task
  
needs/docs
Must have documentation written

  
needs/research
Discuss the ideal implementation with the tech lead

  
needs/upstream
Needs a contribution to an upstream project

  
type/bug
Something not working as intended

  
type/external
Lives outside of code

  
type/feature
New functionality

  
type/refactor
Improving existing code

  
urgency
high
 This is currently causing issues

  
urgency
immediate
 This is making a project or feature unusable

  
urgency
low
 This can happen whenever

  
urgency
medium
 This is expected to cause issues soon

No labels
first-task
needs/docs
needs/research
needs/upstream
type/bug
type/external
type/feature
type/refactor
urgency
high
urgency
immediate
urgency
low
urgency
medium
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
ScottyLabs/study!58
No description provided.