ScottyLabs/study
Watch
16
0
Fork
You've already forked study
 1
Code Issues 34 Pull requests 3 Projects 1 Releases Packages Wiki Activity Actions

Center logout highlight in light and dark mode #47

Merged
annadavi merged 2 commits from 43 into ui_change 2026-10-26 02:28:46 +00:00
Conversation 4 Commits 2 Files changed 2 +34 -1
kenneth4 commented 2026-09-26 22:03:52 +00:00
Member
Copy link

Description

Fixed the centering and padding issues in the log out button.

Closes #43

Type of change

  • Bug fix
  • New feature
  • Refactor / code improvement
  • Test coverage
  • Documentation

Testing

  • I added/updated tests.
  • I tested my changes locally.
    • I tested my changes with a laptop-size screen.
    • I tested my changes with a phone-size screen.
    • I tested my changes with a tablet-size screen.
  • I tested on the dev app (dev.cmustudy.com)

Screenshots/Recordings

Checklist

  • My code follows the project's existing style.
  • I have reviewed my changes.
  • Only the necessary files and lines have been changed.
  • This PR is ready for review.
## Description Fixed the centering and padding issues in the log out button. Closes #43 ## Type of change - [x] Bug fix - [ ] New feature - [ ] Refactor / code improvement - [ ] Test coverage - [ ] Documentation ## Testing - [x] I added/updated tests. - [x] I tested my changes locally. - [x] I tested my changes with a laptop-size screen. - [x] I tested my changes with a phone-size screen. - [ ] I tested my changes with a tablet-size screen. - [ ] I tested on the dev app (dev.cmustudy.com) ## Screenshots/Recordings ## Checklist - [x] My code follows the project's existing style. - [x] I have reviewed my changes. - [x] Only the necessary files and lines have been changed. - [x] This PR is ready for review.
Center logout highlight in light and dark mode
Some checks failed
kennel/build skipped: no services or static sites defined
Details
Deploy to Railway Dev / Deploy to Dev (push) Has been cancelled
Details
Test / Unit and integration tests (push) Has been cancelled
Details
Test / Unit and integration tests (pull_request) Has been cancelled
Details
c5a5bd7f6a
annadavi force-pushed 43 from c5a5bd7f6a
Some checks failed
kennel/build skipped: no services or static sites defined
Details
Deploy to Railway Dev / Deploy to Dev (push) Has been cancelled
Details
Test / Unit and integration tests (push) Has been cancelled
Details
Test / Unit and integration tests (pull_request) Has been cancelled
Details
to e0e52f7b6a
All checks were successful
kennel/build skipped: no services or static sites defined
Details
Test / Unit tests (push) Successful in 1m27s
Details
Test / Integration tests (push) Successful in 1m34s
Details
Test / Deploy to Production (push) Has been skipped
Details
Test / Deploy to Dev (push) Successful in 1m32s
Details
2026-09-28 03:04:40 +00:00 Compare
annadavi commented 2026-09-28 03:04:49 +00:00
Member
Copy link

I just added a PR template to the repo. In the future, it will automatically populate new PRs. Since this PR was made before the template existed, please just edit the description, copy the following template into it, and fill in the template:

## Description



## Related Issue


Closes #

## Type of change

- [ ] Bug fix
- [ ] New feature
- [ ] Refactor / code improvement
- [ ] Test coverage
- [ ] Documentation

## Testing

- [ ] I added/updated tests.
- [ ] I tested my changes locally.
    - [ ] I tested my changes with a laptop-size screen.
    - [ ] I tested my changes with a phone-size screen.
    - [ ] I tested my changes with a tablet-size screen.
- [ ] I tested on the dev app (dev.cmustudy.com)

## Screenshots/Recordings



## Checklist

- [ ] My code follows the project's existing style.
- [ ] I have reviewed my changes.
- [ ] Only the necessary files and lines have been changed.
- [ ] This PR is ready for review.
I just added a PR template to the repo. In the future, it will automatically populate new PRs. Since this PR was made before the template existed, please just edit the description, copy the following template into it, and fill in the template: <pre> ## Description <!-- Please provide a description of the issue, the changes you made to fix it, and why they work. It is expected that you understand why your changes work and if you do not understand why at least say as much so a maintainer knows how much to value the PR. No AI slop. --> ## Related Issue <!-- Link the issue this PR addresses, if applicable. --> Closes # ## Type of change - [ ] Bug fix - [ ] New feature - [ ] Refactor / code improvement - [ ] Test coverage - [ ] Documentation ## Testing - [ ] I added/updated tests. - [ ] I tested my changes locally. - [ ] I tested my changes with a laptop-size screen. - [ ] I tested my changes with a phone-size screen. - [ ] I tested my changes with a tablet-size screen. - [ ] I tested on the dev app (dev.cmustudy.com) ## Screenshots/Recordings <!-- If this includes a UI change, attach screenshots on both laptop and mobile. --> ## Checklist - [ ] My code follows the project's existing style. - [ ] I have reviewed my changes. - [ ] Only the necessary files and lines have been changed. - [ ] This PR is ready for review. </pre>
annadavi commented 2026-10-04 02:37:16 +00:00
Member
Copy link

Since this a UI change, please add a screenshot to the description so we can see what it looks like now. For this change, a "before" image would be useful as well (you should be able to get that by just running from ui_change and screenshotting what the same button used to look like).

Since this a UI change, please add a screenshot to the description so we can see what it looks like now. For this change, a "before" image would be useful as well (you should be able to get that by just running from ui_change and screenshotting what the same button used to look like).
Merge branch 'ui_change' into 43
Some checks failed
nixbot/nix-eval evaluation succeeded in 0s (1 warning)
Details
nixbot/nix-build 0 attributes built
Details
kennel/build build succeeded
Details
kennel/deploy deployment healthy
Details
Test / Unit tests (pull_request) Successful in 31s
Details
Test / Integration tests (pull_request) Has been cancelled
Details
f75a6a8a1e
scottylabs-bot commented 2026-10-26 02:25:21 +00:00
Owner
Copy link

Kennel Deployments

Torn down at 2026-10-26 02:28:48 UTC.

<!-- kennel-deployment --> ### Kennel Deployments Torn down at 2026-10-26 02:28:48 UTC.
annadavi approved these changes 2026-10-26 02:28:01 +00:00
annadavi merged commit f75a6a8a1e into ui_change 2026-10-26 02:28:46 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
mishag
cseluzhy
annadavi
Labels
Clear labels   
first-task
  
needs/docs
Must have documentation written

  
needs/research
Discuss the ideal implementation with the tech lead

  
needs/upstream
Needs a contribution to an upstream project

  
type/bug
Something not working as intended

  
type/external
Lives outside of code

  
type/feature
New functionality

  
type/refactor
Improving existing code

  
urgency
high
 This is currently causing issues

  
urgency
immediate
 This is making a project or feature unusable

  
urgency
low
 This can happen whenever

  
urgency
medium
 This is expected to cause issues soon

No labels
first-task
needs/docs
needs/research
needs/upstream
type/bug
type/external
type/feature
type/refactor
urgency
high
urgency
immediate
urgency
low
urgency
medium
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
ScottyLabs/study!47
No description provided.