fix create modal issues in #62 #63 #66

Merged

klaipras merged 7 commits from create-group-modal-fix into ui_change 2026-10-17 22:38:12 +00:00

Conversation 5 Commits 7 Files changed 3 +54 -6

klaipras commented 2026-10-03 21:51:43 +00:00

Member

Copy link

Description

Add a loading spinner to create group button along with lockout to prevent submitting more than once
Force the calendar to stay light mode to prevent inconsistent color

Related Issue

Closes #61 #63 #66

Type of change

Bug Fix/New Features

Testing

• I added/updated tests.
• I tested my changes locally.
  • I tested my changes with a laptop-size screen.
  • I tested my changes with a phone-size screen.
  • I tested my changes with a tablet-size screen.
• I tested on the kennel preview deployment for this pull request.

Screenshots/Recordings

Checklist

• My code follows the project's existing style.
• I have reviewed my changes.
• Only the necessary files and lines have been changed.
• This PR is ready for review.

## Description Add a loading spinner to create group button along with lockout to prevent submitting more than once Force the calendar to stay light mode to prevent inconsistent color ## Related Issue Closes #61 #63 #66 ## Type of change Bug Fix/New Features ## Testing - [x] I added/updated tests. - [x] I tested my changes locally. - [x] I tested my changes with a laptop-size screen. - [x] I tested my changes with a phone-size screen. - [x] I tested my changes with a tablet-size screen. - [ ] I tested on the kennel preview deployment for this pull request. ## Screenshots/Recordings ## Checklist - [x] My code follows the project's existing style. - [x] I have reviewed my changes. - [x] Only the necessary files and lines have been changed. - [x] This PR is ready for review.

Screenshot 2026-10-03 174029.png

115 KiB

Screenshot 2026-10-03 174503.png

65 KiB

klaipras added 4 commits 2026-10-03 21:51:43 +00:00

fix: remove dark background class from calendar ... b4130bc95a

Remove the background class that make the bg of the calendar dark.
The calendar will remain mostly the same in lightm

fix: add lockout to group creation to avoid duplication. 378bac199e

feat: add loading spinner to lockout 534c63c5a1

refactor: separate interactive part from loading spinner ee0c121b33

klaipras changed title from WIP: fix create modal issues in #62 #63 to fix create modal issues in #62 #63 2026-10-03 21:52:03 +00:00

klaipras changed title from fix create modal issues in #62 #63 to WIP: fix create modal issues in #62 #63 2026-10-03 21:52:07 +00:00

klaipras requested reviews from annadavi, mishag, cseluzhy 2026-10-03 21:52:24 +00:00

klaipras changed title from WIP: fix create modal issues in #62 #63 to fix create modal issues in #62 #63 2026-10-03 21:52:38 +00:00

annadavi commented 2026-10-04 03:08:17 +00:00

Member

Copy link

Is it possible to make the calendar in dark mode as well, meaning the background is dark and the text is light?

Is it possible to make the calendar in dark mode as well, meaning the background is dark and the text is light?

klaipras commented 2026-10-04 04:46:16 +00:00

Author

Member

Copy link

I tinker around and overide a bit with the library css for this. I decide to change the default blue color for our red shade we have in the website. Be aware that I need to use !important for some as the order of css imported is kinda wonky, but it shouldn't affect the rest of the app.

What do you think of the result?

I tinker around and overide a bit with the library css for this. I decide to change the default blue color for our red shade we have in the website. Be aware that I need to use !important for some as the order of css imported is kinda wonky, but it shouldn't affect the rest of the app. What do you think of the result?

Screenshot 2026-10-04 004319.png

139 KiB

Screenshot 2026-10-04 004309.png

125 KiB

klaipras commented 2026-10-04 04:47:58 +00:00

Author

Member

Copy link

Old one for comparison

Old one for comparison

Screenshot 2026-10-04 004744.png

107 KiB

annadavi commented 2026-10-04 20:23:29 +00:00

Member

Copy link

That looks great, nice job! Can you just check whether the red you used in the date is the same as the create button? It looks slightly lighter in the light mode screenshot. Also, I don't think you actually pushed those changes, it doesn't show any new commits on this PR.

That looks great, nice job! Can you just check whether the red you used in the date is the same as the create button? It looks slightly lighter in the light mode screenshot. Also, I don't think you actually pushed those changes, it doesn't show any new commits on this PR.

klaipras added 2 commits 2026-10-17 20:41:12 +00:00

feat: add dark theme for calendar picker d0b66a3e50

Merge branch 'ui_change' of ssh://git.cmu.dev/ScottyLabs/study into create-group-modal-fix 1fc615bc22

klaipras commented 2026-10-17 20:42:46 +00:00

Author

Member

Copy link

Just pushed here. @annadavi The red color that is inconsistent is for the :hover state. My mistake for not moving the cursor away.

Just pushed here. @annadavi The red color that is inconsistent is for the :hover state. My mistake for not moving the cursor away.

klaipras added 1 commit 2026-10-17 22:36:41 +00:00

Merge branch 'ui_change' into create-group-modal-fix 6b51c98f1b

klaipras merged commit 92f5040e12 into ui_change 2026-10-17 22:38:12 +00:00

klaipras deleted branch create-group-modal-fix 2026-10-17 22:38:12 +00:00

klaipras referenced this pull request from a commit 2026-10-17 22:38:12 +00:00

Merge pull request 'fix create modal issues in #62 #63' (#66) from create-group-modal-fix into ui_change

Sign in to join this conversation.

Reviewers

No reviewers

mishag

annadavi

cseluzhy

Labels

Clear labels   

first-task

  

needs/docs

Must have documentation written

  

needs/research

Discuss the ideal implementation with the tech lead

  

needs/upstream

Needs a contribution to an upstream project

  

type/bug

Something not working as intended

  

type/external

Lives outside of code

  

type/feature

New functionality

  

type/refactor

Improving existing code

  

urgency

high

This is currently causing issues

  

urgency

immediate

This is making a project or feature unusable

  

urgency

low

This can happen whenever

  

urgency

medium

This is expected to cause issues soon

No labels

first-task

needs/docs

needs/research

needs/upstream

type/bug

type/external

type/feature

type/refactor

urgency

high

urgency

immediate

urgency

low

urgency

medium

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

ScottyLabs/study!66

No description provided.