feat: added committees page and revised other page headers for consistency #5
No reviewers
Labels
No labels
needs/docs
needs/research
needs/upstream
type/bug
type/external
type/feature
type/refactor
urgency
high
urgency
immediate
urgency
low
urgency
medium
No milestone
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
ScottyLabs/scottylabs-org!5
Loading…
Reference in a new issue
No description provided.
Delete branch "zhihanc/committees-page"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Demo of page is shown below
@ -0,0 +23,4 @@export const APPLICATION_FORM_URL = "https://go.scottylabs.org/apply";/** Fall 2026 recruitment state, from the live `config.recruitingOpen` flag. */minor issue i have with this comment: i think config.recruitingOpen is hardcoded and this comment kinda implies it is fetched dynamically
@ -0,0 +17,4 @@.year-label {font-weight: 700;font-size: var(--text-xl);color: #07123b;other colors in this file uses things like
var(--black-900), ideally match that@ -0,0 +74,4 @@<p className={css["apply-caption"]}>One application covers every committee — rank the ones you're excitedabout.{" "}<Link to={APPLICATION_FORM_URL} target="_blank">not fully sure if this should be
<Link>tag or<a>tag. I think the former is for internal links only but the APPLICATION_FORM_URL is an external link@ -0,0 +49,4 @@{tag && <code className={css["tag"]}>{tag}</code>}</div>{subtitle && <h2 className={css["subtitle"]}>{subtitle}</h2>}{description && <h3 className={css["description"]}>{description}</h3>}these body texts are written using header segments. Is that right? ideally use p or div
Pull request closed