feat: added committees page and revised other page headers for consistency #5

Closed
zhihanc wants to merge 20 commits from zhihanc/committees-page into main AGit
Contributor

Demo of page is shown below

Demo of page is shown below
feat: added committees page and revised other page headers for consistency
All checks were successful
kennel/build skipped: no services or static sites defined
a2c52bbbd6
@ -0,0 +23,4 @@
export const APPLICATION_FORM_URL = "https://go.scottylabs.org/apply";
/** Fall 2026 recruitment state, from the live `config.recruitingOpen` flag. */
Owner

minor issue i have with this comment: i think config.recruitingOpen is hardcoded and this comment kinda implies it is fetched dynamically

minor issue i have with this comment: i think config.recruitingOpen is hardcoded and this comment kinda implies it is fetched dynamically
@ -0,0 +17,4 @@
.year-label {
font-weight: 700;
font-size: var(--text-xl);
color: #07123b;
Owner

other colors in this file uses things like var(--black-900), ideally match that

other colors in this file uses things like `var(--black-900)`, ideally match that
@ -0,0 +74,4 @@
<p className={css["apply-caption"]}>
One application covers every committee — rank the ones you're excited
about.{" "}
<Link to={APPLICATION_FORM_URL} target="_blank">
Owner

not fully sure if this should be <Link> tag or <a> tag. I think the former is for internal links only but the APPLICATION_FORM_URL is an external link

not fully sure if this should be `<Link>` tag or `<a>` tag. I think the former is for internal links only but the APPLICATION_FORM_URL is an external link
@ -0,0 +49,4 @@
{tag && <code className={css["tag"]}>{tag}</code>}
</div>
{subtitle && <h2 className={css["subtitle"]}>{subtitle}</h2>}
{description && <h3 className={css["description"]}>{description}</h3>}
Owner

these body texts are written using header segments. Is that right? ideally use p or div

these body texts are written using header segments. Is that right? ideally use p or div
anish closed this pull request 2026-10-13 14:42:29 +00:00
All checks were successful
kennel/build skipped: no services or static sites defined

Pull request closed

Sign in to join this conversation.
No description provided.