feat/visualizer-fit-zoom #2

Open
alexac wants to merge 2 commits from feat/visualizer-fit-zoom into hotfix
Member
  • Fit each floor to the view when it opens. Zoom limits are now relative to that fit, so it works with both the old data's drawing units and the new meter-based data.
  • Nodes, edges, outlines and labels now stay a constant size on screen at any zoom. The size slider is now in pixels (default 4).
  • Remove the dead "Show PDF" / "Show Outline" toggles and their f/o shortcuts (their code was deleted in 9163194c).

Tested on buildings from the old dataset. Checked visually that nodes, edges, and labels all render at the correct size.

- Fit each floor to the view when it opens. Zoom limits are now relative to that fit, so it works with both the old data's drawing units and the new meter-based data. - Nodes, edges, outlines and labels now stay a constant size on screen at any zoom. The size slider is now in pixels (default 4). - Remove the dead "Show PDF" / "Show Outline" toggles and their f/o shortcuts (their code was deleted in 9163194c). Tested on buildings from the old dataset. Checked visually that nodes, edges, and labels all render at the correct size.
Floors opened at a fixed 1x zoom, so historical data whose drawing units
span only a few units rendered tiny and covered by oversized nodes. Fit
each floor to the view when it loads, clamp zoom relative to that fit, and
size nodes, edges, outlines and labels in screen pixels.
chore(visualizer): remove dead PDF and outline toggles
Some checks failed
nixbot/nix-eval evaluation failed
nixbot/nix-build build failed
kennel/build skipped: no services or static sites defined
Development launcher / launcher (macos-latest) (pull_request) Has been cancelled
Development launcher / launcher (ubuntu-latest) (pull_request) Has been cancelled
Development launcher / launcher (windows-latest) (pull_request) Has been cancelled
Development launcher / native-services (macos-latest) (pull_request) Has been cancelled
Development launcher / native-services (ubuntu-latest) (pull_request) Has been cancelled
94b9a5f71d
The PDF viewer and outline display were deleted in 9163194c, leaving
visibility toggles, keyboard shortcuts and help text that did nothing.
Some checks failed
nixbot/nix-eval evaluation failed
nixbot/nix-build build failed
kennel/build skipped: no services or static sites defined
Development launcher / launcher (macos-latest) (pull_request) Has been cancelled
Development launcher / launcher (ubuntu-latest) (pull_request) Has been cancelled
Development launcher / launcher (windows-latest) (pull_request) Has been cancelled
Development launcher / native-services (macos-latest) (pull_request) Has been cancelled
Development launcher / native-services (ubuntu-latest) (pull_request) Has been cancelled
This pull request can be merged automatically.
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin feat/visualizer-fit-zoom:feat/visualizer-fit-zoom
git switch feat/visualizer-fit-zoom

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch hotfix
git merge --no-ff feat/visualizer-fit-zoom
git switch feat/visualizer-fit-zoom
git rebase hotfix
git switch hotfix
git merge --ff-only feat/visualizer-fit-zoom
git switch feat/visualizer-fit-zoom
git rebase hotfix
git switch hotfix
git merge --no-ff feat/visualizer-fit-zoom
git switch hotfix
git merge --squash feat/visualizer-fit-zoom
git switch hotfix
git merge --ff-only feat/visualizer-fit-zoom
git switch hotfix
git merge feat/visualizer-fit-zoom
git push origin hotfix
Sign in to join this conversation.
No description provided.