ScottyLabs/lost-and-found
Watch
5
0
Fork
You've already forked lost-and-found
 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix download button #208

Merged
michellejli77 merged 9 commits from mli6-fix-item-download into main 2023-03-20 22:13:52 +00:00
Conversation 2 Commits 9 Files changed 2 +3 -3
michellejli77 commented 2023-03-20 19:57:53 +00:00 (Migrated from github.com)
Copy link

Description

Previously, the download button would download the same data regardless of what page the user is on. The download button on the active page should only download active items into a csv and same for the archived page.

Closes #207

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
# Description Previously, the download button would download the same data regardless of what page the user is on. The download button on the active page should only download active items into a csv and same for the archived page. Closes #207 ## Type of change <!-- Please delete options that are not relevant. --> - [x] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] This change requires a documentation update
hdavidethan (Migrated from github.com) approved these changes 2023-03-20 20:20:48 +00:00
hdavidethan (Migrated from github.com) left a comment
Copy link

Other than the part that can more concise, everything looks good!

Other than the part that can more concise, everything looks good!
client/src/components/TableWidget.tsx
@ -56,7 +56,7 @@ const TableWidget = (props: {
<div>
hdavidethan (Migrated from github.com) commented 2023-03-20 20:19:31 +00:00
Copy link

Can simplify to

<DownloadDataButton onlyArchived={props.isArchivedItems} />
Can simplify to ``` <DownloadDataButton onlyArchived={props.isArchivedItems} /> ```
michellejli77 (Migrated from github.com) reviewed 2023-03-20 20:21:37 +00:00
client/src/components/TableWidget.tsx
@ -56,7 +56,7 @@ const TableWidget = (props: {
<div>
michellejli77 (Migrated from github.com) commented 2023-03-20 20:21:36 +00:00
Copy link

o so true

o so true
Sign in to join this conversation.
Reviewers
No reviewers
hdavidethan
Labels
Clear labels   
bootcamp
Bootcamp Task

  
bug
Something isn't working

  
documentation
Improvements or additions to documentation

  
duplicate
This issue or pull request already exists

  
enhancement
New feature or request

  
good first issue
Good for newcomers

  
help wanted
Extra attention is needed

  
invalid
This doesn't seem right

  
question
Further information is requested

  
wontfix
This will not be worked on

  
needs/docs
Must have documentation written

  
needs/research
Discuss the ideal implementation with the tech lead

  
needs/upstream
Needs a contribution to an upstream project

  
type/bug
Something not working as intended

  
type/external
Lives outside of code

  
type/feature
New functionality

  
type/refactor
Improving existing code

  
urgency
high
 This is currently causing issues

  
urgency
immediate
 This is making a project or feature unusable

  
urgency
low
 This can happen whenever

  
urgency
medium
 This is expected to cause issues soon

No labels
bootcamp
bug
documentation
duplicate
enhancement
good first issue
help wanted
invalid
question
wontfix
needs/docs
needs/research
needs/upstream
type/bug
type/external
type/feature
type/refactor
urgency
high
urgency
immediate
urgency
low
urgency
medium
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
ScottyLabs/lost-and-found!208
No description provided.