ScottyLabs/lost-and-found
Watch
5
0
Fork
You've already forked lost-and-found
 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Eblu dropdown #200

Merged
Ethan7894 merged 4 commits from eblu-dropdown into main 2023-02-25 19:49:02 +00:00
Conversation 2 Commits 4 Files changed 1 +9 -9
Ethan7894 commented 2023-02-18 21:21:53 +00:00 (Migrated from github.com)
Copy link

Description

Closes #196

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • Test A
  • Test B

Test Configuration:

  • Node.js version:
  • Python version:
  • Desktop/Mobile:
  • OS:
  • Browser:

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
# Description <!-- Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change. --> Closes #196 ## Type of change <!-- Please delete options that are not relevant. --> - [x] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] This change requires a documentation update # How Has This Been Tested? <!-- Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration --> - [ ] Test A - [ ] Test B **Test Configuration**: <!-- Please remove sections that are not relevant. --> - Node.js version: - Python version: - Desktop/Mobile: - OS: - Browser: # Checklist: - [ ] My code follows the style guidelines of this project - [x] I have performed a self-review of my code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes
michellejli77 (Migrated from github.com) requested changes 2023-02-24 16:49:05 +00:00
michellejli77 (Migrated from github.com) left a comment
Copy link

looks good!
some small things: fix linting issues, and in the pr description, link the issue number using # and remove the spaces in the [] boxes

looks good! some small things: fix linting issues, and in the pr description, link the issue number using # and remove the spaces in the [] boxes
michellejli77 (Migrated from github.com) approved these changes 2023-02-25 19:48:40 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
michellejli77
Labels
Clear labels   
bootcamp
Bootcamp Task

  
bug
Something isn't working

  
documentation
Improvements or additions to documentation

  
duplicate
This issue or pull request already exists

  
enhancement
New feature or request

  
good first issue
Good for newcomers

  
help wanted
Extra attention is needed

  
invalid
This doesn't seem right

  
question
Further information is requested

  
wontfix
This will not be worked on

  
needs/docs
Must have documentation written

  
needs/research
Discuss the ideal implementation with the tech lead

  
needs/upstream
Needs a contribution to an upstream project

  
type/bug
Something not working as intended

  
type/external
Lives outside of code

  
type/feature
New functionality

  
type/refactor
Improving existing code

  
urgency
high
 This is currently causing issues

  
urgency
immediate
 This is making a project or feature unusable

  
urgency
low
 This can happen whenever

  
urgency
medium
 This is expected to cause issues soon

No labels
bootcamp
bug
documentation
duplicate
enhancement
good first issue
help wanted
invalid
question
wontfix
needs/docs
needs/research
needs/upstream
type/bug
type/external
type/feature
type/refactor
urgency
high
urgency
immediate
urgency
low
urgency
medium
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
ScottyLabs/lost-and-found!200
No description provided.