eblu/<display who archived> #192

Merged
Ethan7894 merged 7 commits from archival-history-v3 into main 2022-12-03 20:06:22 +00:00
Ethan7894 commented 2022-12-03 19:36:35 +00:00 (Migrated from github.com)

Description

This pull request allows admins to see the email of the person who archived the items.

Closes #190

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

I tested this by first creating a new item and archiving the item. Then, I checked if I can see my email on the archiver tab. Next, I unarchived that item and asked someone else to rearchive it. After that, checked if the other person's email is showing up on the archiver tab.

  • Test A
  • Test B

Test Configuration:

  • Node.js version:v18.12.1.
  • Python version:3.9.12
  • OS: 11.6
  • Browser:Chrome

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
# Description This pull request allows admins to see the email of the person who archived the items. <!-- Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change. --> Closes #190 ## Type of change <!-- Please delete options that are not relevant. --> - [ ] Bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] This change requires a documentation update # How Has This Been Tested? <!-- Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration --> I tested this by first creating a new item and archiving the item. Then, I checked if I can see my email on the archiver tab. Next, I unarchived that item and asked someone else to rearchive it. After that, checked if the other person's email is showing up on the archiver tab. - [ ] Test A - [ ] Test B **Test Configuration**: <!-- Please remove sections that are not relevant. --> - Node.js version:v18.12.1. - Python version:3.9.12 - OS: 11.6 - Browser:Chrome # Checklist: - [ ] My code follows the style guidelines of this project - [x] I have performed a self-review of my code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes
elouiestudent (Migrated from github.com) approved these changes 2022-12-03 20:05:48 +00:00
elouiestudent (Migrated from github.com) left a comment

LGTM!

LGTM!
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
ScottyLabs/lost-and-found!192
No description provided.