fix: add missing apartment and studio room type rendering in building comparison #109

Closed
kluoxx wants to merge 1 commit from fix/comparison-apartment-room-types into main
Member

The building comparison component (BuildingColumn.tsx) only rendered 6 of the 9 RoomType enum values — it was missing SemiSuiteQuad, ApartmentTriple, StudioApartmentSingle, and StudioApartmentDouble. As a result, buildings whose room types are exclusively drawn from these missing values (e.g. Residence on Fifth, which only has ApartmentTriple and StudioApartmentDouble) showed a completely empty "Room Types" section.

This likely happened because this component wasn't updated when those room types were added to the enum, even though the equivalent section in BuildingDetails.tsx already handles all 9 correctly.

Fix: added the 4 missing conditional render blocks, matching the existing pattern and reusing icons/labels consistent with BuildingDetails.tsx.

Fixes #85.

The building comparison component (BuildingColumn.tsx) only rendered 6 of the 9 RoomType enum values — it was missing SemiSuiteQuad, ApartmentTriple, StudioApartmentSingle, and StudioApartmentDouble. As a result, buildings whose room types are exclusively drawn from these missing values (e.g. Residence on Fifth, which only has ApartmentTriple and StudioApartmentDouble) showed a completely empty "Room Types" section. This likely happened because this component wasn't updated when those room types were added to the enum, even though the equivalent section in BuildingDetails.tsx already handles all 9 correctly. Fix: added the 4 missing conditional render blocks, matching the existing pattern and reusing icons/labels consistent with BuildingDetails.tsx. Fixes #85.
fix: add missing apartment and studio room type rendering in building comparison
Some checks failed
kennel/build build failed
CI / check-openapi (pull_request) Successful in 8m54s
CI / check-1 (pull_request) Failing after 7m57s
CI / build (pull_request) Failing after 12m35s
CI / check (pull_request) Failing after 0s
PR size / size (pull_request) Successful in 4s
PR title / lint (pull_request) Successful in 0s
89b021cde5
kluoxx force-pushed fix/comparison-apartment-room-types from 89b021cde5
Some checks failed
kennel/build build failed
CI / check-openapi (pull_request) Successful in 8m54s
CI / check-1 (pull_request) Failing after 7m57s
CI / build (pull_request) Failing after 12m35s
CI / check (pull_request) Failing after 0s
PR size / size (pull_request) Successful in 4s
PR title / lint (pull_request) Successful in 0s
to aa94e0f7b1
Some checks failed
kennel/build build failed
PR size / size (pull_request) Successful in 4s
PR title / lint (pull_request) Successful in 0s
CI / check-openapi (pull_request) Successful in 3m25s
CI / check-1 (pull_request) Failing after 1m51s
CI / build (pull_request) Successful in 6m49s
CI / check (pull_request) Failing after 0s
2026-10-03 20:30:53 +00:00
Compare
gostmeaper left a comment

Some Changes to be Done:

  1. Package-lock.json and package.json both got regenerated for some reason. This was unnecessary please revert it to match main. Aka delete package-lock.json and revert package.json.
  2. You'll need to move the four blocks into the actual Room Types Card and fix the indentation; the first is indented but the rest is indented 1 extra. Maybe run treefmt next time.
  3. You shouldn't need to be updated react router and vite. But if it is needed you'll want to do it in a separate PR (though once again we prob don't need to)
Some Changes to be Done: 1. Package-lock.json and package.json both got regenerated for some reason. This was unnecessary please revert it to match main. Aka delete `package-lock.json` and revert `package.json`. 2. You'll need to move the four blocks into the actual Room Types Card and fix the indentation; the first is indented but the rest is indented 1 extra. Maybe run treefmt next time. 3. You shouldn't need to be updated react router and vite. But if it is needed you'll want to do it in a separate PR (though once again we prob don't need to)
emmawong left a comment

Hi! There's two issues here...

  1. Please move the four new room types above the closing after "Semi-Suite Triple".
  2. We shouldn't be touching the package.json file! Please undo those changes, as they also affect the
    overall build. In terms of the package-lock.json...we should not need this. Please remove that file as well.

Otherwise, please pull the latest changes from main and request another review when done! Thank you!

Hi! There's two issues here... 1. Please move the four new room types above the closing </div> after "Semi-Suite Triple". 2. We shouldn't be touching the package.json file! Please undo those changes, as they also affect the overall build. In terms of the package-lock.json...we should not need this. Please remove that file as well. Otherwise, please pull the latest changes from main and request another review when done! Thank you!
Member

@emmawong wrote in #109 (comment):

Hi! There's two issues here...

  1. Please move the four new room types above the closing after "Semi-Suite Triple".
  2. We shouldn't be touching the package.json file! Please undo those changes, as they also affect the
    overall build. In terms of the package-lock.json...we should not need this. Please remove that file as well.

Otherwise, please pull the latest changes from main and request another review when done! Thank you!

Slow ah tech lead

@emmawong wrote in https://git.cmu.dev/ScottyLabs/housing/pulls/109#issuecomment-17541: > Hi! There's two issues here... > > 1. Please move the four new room types above the closing after "Semi-Suite Triple". > 2. We shouldn't be touching the package.json file! Please undo those changes, as they also affect the > overall build. In terms of the package-lock.json...we should not need this. Please remove that file as well. > > Otherwise, please pull the latest changes from main and request another review when done! Thank you! Slow ah tech lead
Member

No activity here for 21 days. If this is still live, drop a comment or push something and I'll clear the label. Otherwise it'll be unassigned on the next sweep.

No activity here for 21 days. If this is still live, drop a comment or push something and I'll clear the label. Otherwise it'll be unassigned on the next sweep.
Member

fixed in pr #129

fixed in pr #129
NikhilR closed this pull request 2026-11-03 19:48:49 +00:00
Some checks are pending
kennel/build build failed
PR size / size (pull_request) Successful in 4s
PR title / lint (pull_request) Successful in 0s
CI / check-openapi (pull_request) Successful in 3m25s
CI / check-1 (pull_request) Failing after 1m51s
CI / build (pull_request) Successful in 6m49s
CI / check (pull_request) Failing after 0s
nixbot/nix-eval
Required
nixbot/nix-build
Required
CI / checks*
Required
kennel/deploy
Required

Pull request closed

Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
4 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
ScottyLabs/housing!109
No description provided.