fix: add missing apartment and studio room type rendering in building comparison #109
No reviewers
Labels
No labels
backend
beginner friendly
bug
chore
documentation
enhancement
frontend
needs-triage
no-stale
priority/high
priority/low
priority/medium
size/L
size/M
size/S
size/XL
size/XS
stage/backlog
stage/done
stage/in progress
stage/in-progress
stage/ready
stale
wontfix
needs/docs
needs/research
needs/upstream
type/bug
type/external
type/feature
type/refactor
urgency
high
urgency
immediate
urgency
low
urgency
medium
No milestone
No project
No assignees
4 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
ScottyLabs/housing!109
Loading…
Reference in a new issue
No description provided.
Delete branch "fix/comparison-apartment-room-types"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
The building comparison component (BuildingColumn.tsx) only rendered 6 of the 9 RoomType enum values — it was missing SemiSuiteQuad, ApartmentTriple, StudioApartmentSingle, and StudioApartmentDouble. As a result, buildings whose room types are exclusively drawn from these missing values (e.g. Residence on Fifth, which only has ApartmentTriple and StudioApartmentDouble) showed a completely empty "Room Types" section.
This likely happened because this component wasn't updated when those room types were added to the enum, even though the equivalent section in BuildingDetails.tsx already handles all 9 correctly.
Fix: added the 4 missing conditional render blocks, matching the existing pattern and reusing icons/labels consistent with BuildingDetails.tsx.
Fixes #85.
89b021cde5aa94e0f7b1Some Changes to be Done:
package-lock.jsonand revertpackage.json.Hi! There's two issues here...
overall build. In terms of the package-lock.json...we should not need this. Please remove that file as well.
Otherwise, please pull the latest changes from main and request another review when done! Thank you!
@emmawong wrote in #109 (comment):
Slow ah tech lead
No activity here for 21 days. If this is still live, drop a comment or push something and I'll clear the label. Otherwise it'll be unassigned on the next sweep.
fixed in pr #129
Pull request closed