ScottyLabs/housing
Watch
17
0
Fork
You've already forked housing
 4
Code Issues 17 Pull requests 7 Projects 1 Releases Packages Wiki Activity Actions 2

fix: add missing apartment and studio room type rendering in building comparison #109

Open
kluoxx wants to merge 1 commit from fix/comparison-apartment-room-types into main
pull from: fix/comparison-apartment-room-types
merge into: ScottyLabs:main
Conversation 0 Commits 1 Files changed 5 +2903 -4
kluoxx commented 2026-10-02 01:36:33 +00:00
Member
Copy link

The building comparison component (BuildingColumn.tsx) only rendered 6 of the 9 RoomType enum values — it was missing SemiSuiteQuad, ApartmentTriple, StudioApartmentSingle, and StudioApartmentDouble. As a result, buildings whose room types are exclusively drawn from these missing values (e.g. Residence on Fifth, which only has ApartmentTriple and StudioApartmentDouble) showed a completely empty "Room Types" section.

This likely happened because this component wasn't updated when those room types were added to the enum, even though the equivalent section in BuildingDetails.tsx already handles all 9 correctly.

Fix: added the 4 missing conditional render blocks, matching the existing pattern and reusing icons/labels consistent with BuildingDetails.tsx.

Fixes #85.

The building comparison component (BuildingColumn.tsx) only rendered 6 of the 9 RoomType enum values — it was missing SemiSuiteQuad, ApartmentTriple, StudioApartmentSingle, and StudioApartmentDouble. As a result, buildings whose room types are exclusively drawn from these missing values (e.g. Residence on Fifth, which only has ApartmentTriple and StudioApartmentDouble) showed a completely empty "Room Types" section. This likely happened because this component wasn't updated when those room types were added to the enum, even though the equivalent section in BuildingDetails.tsx already handles all 9 correctly. Fix: added the 4 missing conditional render blocks, matching the existing pattern and reusing icons/labels consistent with BuildingDetails.tsx. Fixes #85.
fix: add missing apartment and studio room type rendering in building comparison
Some checks failed
kennel/build build failed
Details
CI / check-openapi (pull_request) Successful in 8m54s
Details
CI / check-1 (pull_request) Failing after 7m57s
Details
CI / build (pull_request) Failing after 12m35s
Details
CI / check (pull_request) Failing after 0s
Details
PR size / size (pull_request) Successful in 4s
Details
PR title / lint (pull_request) Successful in 0s
Details
89b021cde5
Some checks failed
kennel/build build failed
Details
CI / check-openapi (pull_request) Successful in 8m54s
Details
CI / check-1 (pull_request) Failing after 7m57s
Details
CI / build (pull_request) Failing after 12m35s
Details
CI / check (pull_request) Failing after 0s
Details
PR size / size (pull_request) Successful in 4s
Details
PR title / lint (pull_request) Successful in 0s
Details
This pull request doesn't have enough approvals yet. 0 of 1 approvals granted.
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin fix/comparison-apartment-room-types:fix/comparison-apartment-room-types
git switch fix/comparison-apartment-room-types
Sign in to join this conversation.
Reviewers
No reviewers
NikhilR
emmawong
Labels
Clear labels   
backend
apps/backend

  
beginner friendly
Good first issue for a new member

  
bug
Something isn't working

  
chore
Maintenance, tooling, dependencies

  
documentation
Docs and READMEs

  
enhancement
New feature or request

  
frontend
apps/frontend

  
needs-triage
Not yet sized, prioritised or staged

  
no-stale
Exempt from the stale nudge

  
priority/high
Blocking or time-sensitive

  
priority/low
Nice to have

  
priority/medium
Normal priority

  
size/L
Under 600 changed lines

  
size/M
Under 200 changed lines

  
size/S
Under 50 changed lines

  
size/XL
600+ changed lines - consider splitting it

  
size/XS
Under 10 changed lines

  
stage/backlog
Parked on purpose - not up for grabs yet

  
stage/done
Closed

  
stage/in progress
Issue is in progress

  
stage/in-progress
Someone is assigned and working on it

  
stage/ready
Unassigned and ready for someone to pick up

  
stale
No activity for a while - applied by stale.yml

  
wontfix
This will not be worked on

  
needs/docs
Must have documentation written

  
needs/research
Discuss the ideal implementation with the tech lead

  
needs/upstream
Needs a contribution to an upstream project

  
type/bug
Something not working as intended

  
type/external
Lives outside of code

  
type/feature
New functionality

  
type/refactor
Improving existing code

  
urgency
high
 This is currently causing issues

  
urgency
immediate
 This is making a project or feature unusable

  
urgency
low
 This can happen whenever

  
urgency
medium
 This is expected to cause issues soon

No labels
backend
beginner friendly
bug
chore
documentation
enhancement
frontend
needs-triage
no-stale
priority/high
priority/low
priority/medium
size/L
size/M
size/S
size/XL
size/XS
stage/backlog
stage/done
stage/in progress
stage/in-progress
stage/ready
stale
wontfix
needs/docs
needs/research
needs/upstream
type/bug
type/external
type/feature
type/refactor
urgency
high
urgency
immediate
urgency
low
urgency
medium
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
ScottyLabs/housing!109
No description provided.