ScottyLabs/housing
Watch
17
0
Fork
You've already forked housing
 4
Code Issues 18 Pull requests 5 Projects 1 Releases Packages Wiki Activity Actions

feat: added location data to buildings.json and add endpoint to maps config #115

Merged
NikhilR merged 26 commits from rhsen-housing into main 2026-10-31 21:01:23 +00:00
Conversation 4 Commits 26 Files changed 7 +154 -60
gostmeaper commented 2026-10-12 05:02:09 +00:00
Member
Copy link

takes on #101

takes on #101
fix: corrected typos in buildings.json
Some checks failed
PR title / lint (pull_request) Successful in 0s
Details
PR size / size (pull_request) Has been skipped
Details
kennel/build build succeeded
Details
kennel/deploy provisioning declared resource 'postgres' failed: psql failed [GRANT CREATE ON DATABASE "kennel_019eaa84_574f_7af2_965e_4f872de9e728_pr_101" TO "kennel_019eaa84_574f_7af2_965e_4f872de9e728_pr_101_owner"]: ERROR: database "kennel_019eaa84_574f_7af2_965e_4f872de9e728_pr_101" does not exist
Details
CI / check (pull_request) Has been cancelled
Details
CI / check-1 (pull_request) Has been cancelled
Details
CI / build (pull_request) Has been cancelled
Details
CI / check-openapi (pull_request) Has been cancelled
Details
2ac2f26199
fix: corrected typos in buildings.json
Some checks failed
PR size / size (pull_request) Has been skipped
Details
kennel/build build succeeded
Details
kennel/deploy provisioning declared resource 'postgres' failed: psql failed [GRANT CREATE ON DATABASE "kennel_019eaa84_574f_7af2_965e_4f872de9e728_pr_101" TO "kennel_019eaa84_574f_7af2_965e_4f872de9e728_pr_101_owner"]: ERROR: database "kennel_019eaa84_574f_7af2_965e_4f872de9e728_pr_101" does not exist
Details
CI / check-openapi (pull_request) Successful in 1m9s
Details
CI / check-1 (pull_request) Failing after 14s
Details
CI / build (pull_request) Failing after 15s
Details
PR title / lint (pull_request) Successful in 0s
Details
CI / check (pull_request) Failing after 0s
Details
f4b4c23fb2
feat: added endpoint to fetch maps config
Some checks failed
PR size / size (pull_request) Has been skipped
Details
kennel/build build succeeded
Details
kennel/deploy secret resolution failed for service 'backend': Secret 'GOOGLE_MAPS_API_KEY' is required but not set
Details
CI / check-openapi (pull_request) Failing after 1m8s
Details
CI / check-1 (pull_request) Failing after 14s
Details
CI / build (pull_request) Failing after 15s
Details
CI / check (pull_request) Failing after 0s
Details
PR title / lint (pull_request) Successful in 0s
Details
a33ee883c6
Merge branch 'main' of ssh://git.cmu.dev/rhsen/housing
Some checks failed
PR size / size (pull_request) Has been skipped
Details
kennel/build build succeeded
Details
kennel/deploy deployment healthy
Details
PR title / lint (pull_request) Successful in 0s
Details
CI / check (pull_request) Has been cancelled
Details
CI / check-openapi (pull_request) Has been cancelled
Details
CI / check-1 (pull_request) Has been cancelled
Details
CI / build (pull_request) Has been cancelled
Details
05dd99c862
Merge branch 'main' of ssh://git.cmu.dev/rhsen/housing
Some checks failed
PR size / size (pull_request) Has been skipped
Details
kennel/build build succeeded
Details
kennel/deploy deployment healthy
Details
CI / check-openapi (pull_request) Failing after 1m13s
Details
CI / check-1 (pull_request) Failing after 16s
Details
CI / build (pull_request) Failing after 14s
Details
CI / check (pull_request) Failing after 0s
Details
PR title / lint (pull_request) Successful in 0s
Details
763643ea83
chore: updated openapi
Some checks failed
CI / check (pull_request) Successful in 0s
Details
CI / build (pull_request) Successful in 2m25s
Details
PR size / size (pull_request) Successful in 4s
Details
PR title / lint (pull_request) Successful in 0s
Details
CI / check-openapi (pull_request) Failing after 1m15s
Details
kennel/build build succeeded
Details
CI / check-1 (pull_request) Successful in 1m54s
Details
kennel/deploy deployment healthy
Details
7d83dd9504
gostmeaper reviewed 2026-10-12 05:11:47 +00:00
gostmeaper left a comment
Copy link

Currently as it is written the endpoint for the map is public and will return the API key. This is because it is used before we do sessionAuth route. So anyone can fetch it before any authentication. We want to move it after sessionAuth route:

  1. use .use(sessionAuth) in mapsRoute and make the requisite 401 error response
  2. then just rerun the open api generation
Currently as it is written the endpoint for the map is public and will return the API key. This is because it is used before we do sessionAuth route. So anyone can fetch it before any authentication. We want to move it after sessionAuth route: 1. use `.use(sessionAuth)` in mapsRoute and make the requisite 401 error response 2. then just rerun the open api generation
apps/backend/src/routes/maps-config.ts Outdated
@ -0,0 +18,4 @@
() => {
const apiKey = Deno.env.get("GOOGLE_MAPS_API_KEY");
if (!apiKey || !mapId) {
gostmeaper commented 2026-10-12 05:08:15 +00:00
Author
Member
Copy link

!mapId

Why are we checking if mapId exists? This is a useless check considering we hard coded it as a const above...

`!mapId` Why are we checking if mapId exists? This is a useless check considering we hard coded it as a const above...
rhsen commented 2026-10-15 16:30:19 +00:00
Member
Copy link

mapId wasn't hardcoded at first, forgot to remove the check.

mapId wasn't hardcoded at first, forgot to remove the check.
gostmeaper commented 2026-10-12 05:12:30 +00:00
Author
Member
Copy link

@rhsen please see the above comments as requested changes.

PS your changes were moved to a branch on the actual housing repo so you'll need to abandon the fork and work on this branch off main.

@rhsen please see the above comments as requested changes. PS your changes were moved to a branch on the actual housing repo so you'll need to abandon the fork and work on this branch off main.
scottylabs-bot commented 2026-10-12 21:20:35 +00:00
Owner
Copy link

Kennel Deployments

Torn down at 2026-10-31 21:01:25 UTC.

<!-- kennel-deployment --> ### Kennel Deployments Torn down at 2026-10-31 21:01:25 UTC.
fix: removed unneccessary tests
Some checks failed
nixbot/nix-eval evaluation succeeded in 0s (1 warning)
Details
nixbot/nix-build 0 attributes built
Details
kennel/build build succeeded
Details
kennel/deploy deployment healthy
Details
PR size / size (pull_request) Successful in 4s
Details
CI / check-openapi (pull_request) Failing after 2m0s
Details
CI / check-1 (pull_request) Successful in 2m17s
Details
CI / build (pull_request) Successful in 3m59s
Details
CI / check (pull_request) Successful in 0s
Details
PR title / lint (pull_request) Successful in 0s
Details
a453d08304
fix: refresh openapi
Some checks failed
PR title / lint (pull_request) Successful in 0s
Details
PR size / size (pull_request) Successful in 5s
Details
nixbot/nix-eval evaluation succeeded in 0s (1 warning)
Details
nixbot/nix-build 0 attributes built
Details
kennel/build build succeeded
Details
kennel/deploy deployment healthy
Details
CI / check-1 (pull_request) Failing after 6m10s
Details
CI / build (pull_request) Failing after 6m50s
Details
CI / check (pull_request) Failing after 0s
Details
CI / check-openapi (pull_request) Successful in 7m0s
Details
3aa0667eab 
revert 8203cb24a5
Signed-off-by: Anish Pallati <i@anish.land>
This will fix our open api check fail.

Reviewed-on: #121
feat(frontend): add dorm review form
Some checks failed
PR title / lint (pull_request) Successful in 0s
Details
nixbot/nix-eval evaluation succeeded
Details
nixbot/nix-build 0 attributes built
Details
PR size / size (pull_request) Successful in 7s
Details
CI / check (pull_request) Has been cancelled
Details
CI / check-1 (pull_request) Has been cancelled
Details
CI / build (pull_request) Has been cancelled
Details
CI / check-openapi (pull_request) Has been cancelled
Details
kennel/build build succeeded
Details
6c37f3f2d5
Merge branch 'main' into rhsen-housing
All checks were successful
nixbot/nix-eval evaluation succeeded
Details
nixbot/nix-build 0 attributes built
Details
PR title / lint (pull_request) Successful in 0s
Details
PR size / size (pull_request) Successful in 7s
Details
CI / check-openapi (pull_request) Successful in 51s
Details
kennel/build build succeeded
Details
kennel/deploy deployment healthy
Details
CI / check-1 (pull_request) Successful in 1m8s
Details
CI / build (pull_request) Successful in 2m16s
Details
CI / check (pull_request) Successful in 0s
Details
963ab4bda8
NikhilR approved these changes 2026-10-31 20:46:28 +00:00
NikhilR deleted branch rhsen-housing 2026-10-31 21:01:23 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
emmawong
NikhilR
Labels
Clear labels   
backend
apps/backend

  
beginner friendly
Good first issue for a new member

  
bug
Something isn't working

  
chore
Maintenance, tooling, dependencies

  
documentation
Docs and READMEs

  
enhancement
New feature or request

  
frontend
apps/frontend

  
needs-triage
Not yet sized, prioritised or staged

  
no-stale
Exempt from the stale nudge

  
priority/high
Blocking or time-sensitive

  
priority/low
Nice to have

  
priority/medium
Normal priority

  
size/L
Under 600 changed lines

  
size/M
Under 200 changed lines

  
size/S
Under 50 changed lines

  
size/XL
600+ changed lines - consider splitting it

  
size/XS
Under 10 changed lines

  
stage/backlog
Parked on purpose - not up for grabs yet

  
stage/done
Closed

  
stage/in progress
Issue is in progress

  
stage/in-progress
Someone is assigned and working on it

  
stage/ready
Unassigned and ready for someone to pick up

  
stale
No activity for a while - applied by stale.yml

  
wontfix
This will not be worked on

  
needs/docs
Must have documentation written

  
needs/research
Discuss the ideal implementation with the tech lead

  
needs/upstream
Needs a contribution to an upstream project

  
type/bug
Something not working as intended

  
type/external
Lives outside of code

  
type/feature
New functionality

  
type/refactor
Improving existing code

  
urgency
high
 This is currently causing issues

  
urgency
immediate
 This is making a project or feature unusable

  
urgency
low
 This can happen whenever

  
urgency
medium
 This is expected to cause issues soon

No labels
backend
beginner friendly
bug
chore
documentation
enhancement
frontend
needs-triage
no-stale
priority/high
priority/low
priority/medium
size/L
size/M
size/S
size/XL
size/XS
stage/backlog
stage/done
stage/in progress
stage/in-progress
stage/ready
stale
wontfix
needs/docs
needs/research
needs/upstream
type/bug
type/external
type/feature
type/refactor
urgency
high
urgency
immediate
urgency
low
urgency
medium
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
4 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
ScottyLabs/housing!115
No description provided.