feat: added location data to buildings.json #101

Closed

rhsen wants to merge 15 commits from rhsen/housing:main into main

pull from: rhsen/housing:main

merge into: ScottyLabs:main

ScottyLabs:main

ScottyLabs:chore/data-cleanup

ScottyLabs:feat/see-more-button

ScottyLabs:fix/profile-placeholder-route

ScottyLabs:renovate/lockfiles

ScottyLabs:fix/dorm-review-frontend

ScottyLabs:feat/posthog

ScottyLabs:renovate/kennel

ScottyLabs:fix/finish-survey-based-home-recommendations-v2

ScottyLabs:fix/resolve-building-tab-highlight-issue

ScottyLabs:feat/rating-survey

ScottyLabs:fix/comparison-apartment-room-types

ScottyLabs:feat/home-recommendations

ScottyLabs:feat/home-page-recommendations

ScottyLabs:openbao-update

ScottyLabs:profile-page

ScottyLabs:survey-link

ScottyLabs:auth

ScottyLabs:update

ScottyLabs:update-devenv

ScottyLabs:fix-devenv

ScottyLabs:fix-spa-fallback

ScottyLabs:building-comparison

ScottyLabs:setup-database-schema

ScottyLabs:add-floor-plan-gallery

Conversation 6 Commits 15 Files changed 7 +212 -60

rhsen commented 2026-09-19 21:31:43 +00:00

Member

Copy link

No description provided.

rhsen added 2 commits 2026-09-19 21:31:43 +00:00

feat: added location data to buildings.json fc77862985

fix: corrected typos in buildings.json 2ac2f26199

rhsen requested reviews from emmawong, NikhilR 2026-09-19 21:31:43 +00:00

anish force-pushed main from 2ac2f26199 to f4b4c23fb2 2026-09-23 00:18:17 +00:00 Compare

gostmeaper added the

size/XS

label 2026-09-25 00:21:29 +00:00

rhsen added 4 commits 2026-09-26 22:01:49 +00:00

feat: added location data to buildings.json fc77862985

fix: corrected typos in buildings.json 2ac2f26199

Merge branch 'main' of ssh://git.cmu.dev/rhsen/housing b66764a7cd

feat: added endpoint to fetch maps config a33ee883c6

NikhilR commented 2026-09-29 03:09:41 +00:00

Member

Copy link

Need someone to go through and verify the lat/long coordinates

Need someone to go through and verify the lat/long coordinates

gostmeaper commented 2026-09-29 04:14:24 +00:00

Member

Copy link

@NikhilR wrote in #101 (comment):

Need someone to go through and verify the lat/long coordinates

I think the reviewer should do that

@NikhilR wrote in https://git.cmu.dev/ScottyLabs/housing/pulls/101#issuecomment-15693: > Need someone to go through and verify the lat/long coordinates I think the reviewer should do that

gostmeaper requested changes 2026-10-01 17:44:35 +00:00

gostmeaper left a comment

Copy link

Can you rebase? This will retrigger the checks which should be fixed now, otherwise if there still is CI problems please fix them.

Also a note for the future: You could've and should've done this in 2 PRs one for the endpoitn for maps and one just doing location data. Please do not try to do multiple issues in one PR. I'd rather you just make multiple PRs or else it become confusing as hell.

Can you rebase? This will retrigger the checks which should be fixed now, otherwise if there still is CI problems please fix them. Also a note for the future: You could've and should've done this in 2 PRs one for the endpoitn for maps and one just doing location data. Please do not try to do multiple issues in one PR. I'd rather you just make multiple PRs or else it become confusing as hell.

rhsen commented 2026-10-01 17:50:54 +00:00

Author

Member

Copy link

ok, mb about the extra issue in the PR i didn't realize this original one was still open.

ok, mb about the extra issue in the PR i didn't realize this original one was still open.

rhsen added 4 commits 2026-10-01 18:03:21 +00:00

feat: added location data to buildings.json 296c360998

fix: corrected typos in buildings.json 8b09d3373b

feat: added endpoint to fetch maps config 19059cfae5

Merge branch 'main' of ssh://git.cmu.dev/rhsen/housing 05dd99c862

scottylabs-bot commented 2026-10-01 18:05:09 +00:00

Owner

Copy link

Kennel Deployments

Service	URL
backend	https://housing-backend-pr-101.scottylabs.net

Last updated for commit 7d83dd9.

<!-- kennel-deployment --> ### Kennel Deployments | Service | URL | | --- | --- | | backend | https://housing-backend-pr-101.scottylabs.net | Last updated for commit `7d83dd9`.

rhsen added 4 commits 2026-10-03 20:42:12 +00:00

feat: added location data to buildings.json 392a53569e

fix: corrected typos in buildings.json cd8c925458

feat: added endpoint to fetch maps config f51be43914

Merge branch 'main' of ssh://git.cmu.dev/rhsen/housing 763643ea83

rhsen added 1 commit 2026-10-03 22:02:39 +00:00

chore: updated openapi 7d83dd9504

gostmeaper referenced this pull request 2026-10-12 05:02:09 +00:00

feat: added location data to buildings.json and add endpoint to maps config #115

gostmeaper commented 2026-10-12 05:02:50 +00:00

Member

Copy link

@rhsen refer to #115

@rhsen refer to #115

gostmeaper closed this pull request 2026-10-12 05:02:50 +00:00

NikhilR referenced this pull request from a commit 2026-10-31 21:01:24 +00:00

feat: added location data to buildings.json and add endpoint to maps config (#115)

Some checks failed

Hide checks

CI / check (pull_request) Successful in 0s

Details

CI / build (pull_request) Successful in 2m25s

Details

PR size / size (pull_request) Successful in 4s

Details

PR title / lint (pull_request) Successful in 0s

Details

CI / check-openapi (pull_request) Failing after 1m15s

Details

kennel/build build succeeded

Details

CI / check-1 (pull_request) Successful in 1m54s

Details

kennel/deploy deployment healthy

Details

Pull request closed

Please reopen this pull request to perform a merge.

Sign in to join this conversation.

Reviewers

No reviewers

emmawong

NikhilR

gostmeaper

Labels

Clear labels   

backend

apps/backend

  

beginner friendly

Good first issue for a new member

  

bug

Something isn't working

  

chore

Maintenance, tooling, dependencies

  

documentation

Docs and READMEs

  

enhancement

New feature or request

  

frontend

apps/frontend

  

needs-triage

Not yet sized, prioritised or staged

  

no-stale

Exempt from the stale nudge

  

priority/high

Blocking or time-sensitive

  

priority/low

Nice to have

  

priority/medium

Normal priority

  

size/L

Under 600 changed lines

  

size/M

Under 200 changed lines

  

size/S

Under 50 changed lines

  

size/XL

600+ changed lines - consider splitting it

  

size/XS

Under 10 changed lines

  

stage/backlog

Parked on purpose - not up for grabs yet

  

stage/done

Closed

  

stage/in progress

Issue is in progress

  

stage/in-progress

Someone is assigned and working on it

  

stage/ready

Unassigned and ready for someone to pick up

  

stale

No activity for a while - applied by stale.yml

  

wontfix

This will not be worked on

  

needs/docs

Must have documentation written

  

needs/research

Discuss the ideal implementation with the tech lead

  

needs/upstream

Needs a contribution to an upstream project

  

type/bug

Something not working as intended

  

type/external

Lives outside of code

  

type/feature

New functionality

  

type/refactor

Improving existing code

  

urgency

high

This is currently causing issues

  

urgency

immediate

This is making a project or feature unusable

  

urgency

low

This can happen whenever

  

urgency

medium

This is expected to cause issues soon

No labels

backend

beginner friendly

bug

chore

documentation

enhancement

frontend

needs-triage

no-stale

priority/high

priority/low

priority/medium

size/L

size/M

size/S

size/XL

size/XS

stage/backlog

stage/done

stage/in progress

stage/in-progress

stage/ready

stale

wontfix

needs/docs

needs/research

needs/upstream

type/bug

type/external

type/feature

type/refactor

urgency

high

urgency

immediate

urgency

low

urgency

medium

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

5 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

ScottyLabs/housing!101

No description provided.