fix: different drawers for different devices #824

2026-04-18T21:37:38Z

cnk2024 commented

2026-04-18 21:37:38 +00:00

(Migrated from github.com)

mobile: bottom sheet or side panel
desktop: full width or side panel

- mobile: bottom sheet or side panel - desktop: full width or side panel

vercel[bot] commented

2026-04-18 21:37:43 +00:00

(Migrated from github.com)

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
cmueats	Ready	Preview	Apr 18, 2026 10:27pm

[vc]: #2OP7utpbVow9o37jo/an5nC5A9YRNURskJdqYaPBr8U=:eyJpc01vbm9yZXBvIjp0cnVlLCJ0eXBlIjoiZ2l0aHViIiwicHJvamVjdHMiOlt7Im5hbWUiOiJjbXVlYXRzIiwicHJvamVjdElkIjoicHJqX1Q5WTRDWmRlMkdtOVFYd2FKWmtNWnZmQWFlMXQiLCJ2MCI6ZmFsc2UsImluc3BlY3RvclVybCI6Imh0dHBzOi8vdmVyY2VsLmNvbS9zY290dHlsYWJzL2NtdWVhdHMvODliY2IxMzJhM0I3R2R1Uzl3S2ZndENqUVNZRiIsInByZXZpZXdVcmwiOiJjbXVlYXRzLWdpdC10d2Vha3MtbW9iaWxlLWRyYXdlci1zY290dHlsYWJzLnZlcmNlbC5hcHAiLCJuZXh0Q29tbWl0U3RhdHVzIjoiREVQTE9ZRUQiLCJyb290RGlyZWN0b3J5IjpudWxsfV0sInJlcXVlc3RSZXZpZXdVcmwiOiJodHRwczovL3ZlcmNlbC5jb20vdmVyY2VsLWFnZW50L3JlcXVlc3QtcmV2aWV3P293bmVyPVNjb3R0eUxhYnMmcmVwbz1jbXVlYXRzJnByPTgyNCJ9 The latest updates on your projects. Learn more about [Vercel for GitHub](https://vercel.link/github-learn-more). | Project | Deployment | Actions | Updated (UTC) | | :--- | :----- | :------ | :------ | | [cmueats](https://vercel.com/scottylabs/cmueats) | ![Ready](https://vercel.com/static/status/ready.svg) [Ready](https://vercel.com/scottylabs/cmueats/89bcb132a3B7GduS9wKfgtCjQSYF) | [Preview](https://cmueats-git-tweaks-mobile-drawer-scottylabs.vercel.app) | Apr 18, 2026 10:27pm | <a href="https://vercel.com/vercel-agent/request-review?owner=ScottyLabs&repo=cmueats&pr=824" rel="noreferrer"><picture><source media="(prefers-color-scheme: dark)" srcset="https://agents-vade-review.vercel.sh/request-review-dark.svg"><source media="(prefers-color-scheme: light)" srcset="https://agents-vade-review.vercel.sh/request-review-light.svg"><img src="https://agents-vade-review.vercel.sh/request-review-light.svg" alt="Request Review"></picture></a>

Arom1a commented

2026-04-19 00:26:40 +00:00

(Migrated from github.com)

Bro why the format check keeps failing 😭

Bro why the format check keeps failing :sob:

Arom1a commented

2026-04-19 00:26:55 +00:00

(Migrated from github.com)

It runs with no error locally

Arom1a (Migrated from github.com) requested changes

2026-04-19 00:30:55 +00:00

Arom1a (Migrated from github.com) left a comment

everything else LGTM!

src/contexts/IsMobileContext.tsx

					
				@ -3,15 +3,16 @@ import { createContext, useContext, useState, useEffect } from 'react';

				const isMobileContext = createContext<boolean | undefined>(undefined);

oops, I think this should be PascalCase

src/contexts/IsMobileContext.tsx

					
				@ -15,3 +15,4 @@

				    }, [isTouchScreen]);

				    return <isMobileContext.Provider value={isMobile}>{children}</isMobileContext.Provider>;

				}

did you leave this here for development purpose? I think in real use cases this don't need to be recalculated every render

This pull request can be merged automatically.

You are not authorized to merge this pull request.

View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.

git fetch -u origin tweaks/mobile-drawer:tweaks/mobile-drawer

git switch tweaks/mobile-drawer

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch staging

git merge --no-ff tweaks/mobile-drawer

git switch tweaks/mobile-drawer

git rebase staging

git switch staging

git merge --ff-only tweaks/mobile-drawer

git switch tweaks/mobile-drawer

git rebase staging

git switch staging

git merge --no-ff tweaks/mobile-drawer

git switch staging

git merge --squash tweaks/mobile-drawer

git switch staging

git merge --ff-only tweaks/mobile-drawer

git switch staging

git merge tweaks/mobile-drawer

git push origin staging

Sign in to join this conversation.

No reviewers

Arom1a

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

ScottyLabs/eats!824

				`@ -3,15 +3,16 @@ import { createContext, useContext, useState, useEffect } from 'react';`
				`const isMobileContext = createContext<boolean \| undefined>(undefined);`

Rows
Columns