WIP: Added menu items and images to api #251

2026-03-23T02:32:35Z

laasyaaki commented

2026-03-23 02:32:35 +00:00

(Migrated from github.com)

The menu PNGs given by dining are now visible directly on cmueats. The items are all searchable and the locations serving those items will pop up. Search "lavender" for example will result in coffee shops showing up when it previously did not yield any results.

sentry[bot] (Migrated from github.com) reviewed

2026-03-23 02:36:14 +00:00

src/db/getLocations.ts

					
				@ -99,0 +101,4 @@

				                ...timeRanges.map((rng) => ({

				                    date: overrideDate,

				                    startMinutesSinceMidnight:

				                        rng.start.hour * 60 + rng.start.minute,

Bug: The menuItemsString field incorrectly returns "" instead of null for missing data, which violates the API's nullable schema definition.
_{Severity: MEDIUM}

Suggested Fix

Change the nullish coalescing operator's fallback value from "" to null to align with the API schema. The line should be updated to menuItemsString: menuData?.menuItemsString ?? null. This ensures the API correctly signals the absence of data to clients.

Prompt for AI Agent

Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.

Location: src/db/getLocations.ts#L57

Potential issue: The `getLocations` function incorrectly handles null values for the
`menuItemsString` field. It uses the nullish coalescing operator `?? ""` to convert
`null` values from the database into an empty string. However, the API schema explicitly
defines this field as nullable (`t.Nullable(t.String())`), and the data loading pipeline
intentionally stores `null` for missing data. This mismatch breaks the API contract, as
clients expecting `null` to signify "no data" will receive an empty string instead,
potentially leading to incorrect client-side logic.

_{Did we get this right? 👍 / 👎 to inform future reviews.}

**Bug:** The `menuItemsString` field incorrectly returns `""` instead of `null` for missing data, which violates the API's nullable schema definition. Severity: MEDIUM  <details> <summary>Suggested Fix</summary> Change the nullish coalescing operator's fallback value from `""` to `null` to align with the API schema. The line should be updated to `menuItemsString: menuData?.menuItemsString ?? null`. This ensures the API correctly signals the absence of data to clients. </details> <details open> <summary>Prompt for AI Agent</summary> ``` Review the code at the location below. A potential bug has been identified by an AI agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not valid. Location: src/db/getLocations.ts#L57 Potential issue: The `getLocations` function incorrectly handles null values for the `menuItemsString` field. It uses the nullish coalescing operator `?? ""` to convert `null` values from the database into an empty string. However, the API schema explicitly defines this field as nullable (`t.Nullable(t.String())`), and the data loading pipeline intentionally stores `null` for missing data. This mismatch breaks the API contract, as clients expecting `null` to signify "no data" will receive an empty string instead, potentially leading to incorrect client-side logic. ``` </details> Did we get this right? :+1: / :-1: to inform future reviews.

This pull request has changes conflicting with the target branch.

src/db/getLocations.ts

View command line instructions

Manual merge helper

Use this merge commit message when completing the merge manually.

Merge commit title

Merge pull request 'WIP: Added menu items and images to api' (#251) from searchable_menus into main

Merge commit body

Reviewed-on: https://git.cmu.dev/ScottyLabs/dining-api/pulls/251

Merge pull request 'WIP: Added menu items and images to api' (#251) from searchable_menus into main

Reviewed-on: https://git.cmu.dev/ScottyLabs/dining-api/pulls/251

Checkout

From your project repository, check out a new branch and test the changes.

git fetch -u origin searchable_menus:searchable_menus

git switch searchable_menus

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch main

git merge --no-ff searchable_menus

git switch searchable_menus

git rebase main

git switch main

git merge --ff-only searchable_menus

git switch searchable_menus

git rebase main

git switch main

git merge --no-ff searchable_menus

git switch main

git merge --squash searchable_menus