Rewrite dining parser in TypeScript #21

2022-07-19T05:26:47Z

hdavidethan commented

2022-07-19 05:26:47 +00:00

(Migrated from github.com)

Rewrote the entire parser in TypeScript and fixed the parsing issues introduced in the summer.

Rewrote the entire parser in TypeScript and fixed the parsing issues introduced in the summer. <img width="1389" alt="image" src="https://user-images.githubusercontent.com/17174688/179671829-3432c7fa-e6ee-4d05-80d2-b00a90759517.png">

gramliu (Migrated from github.com) requested changes

2022-07-19 05:42:33 +00:00

src/containers/locationBuilder.ts

					
				@ -0,0 +30,4 @@

				/**

				 * For building the location data structure

				 */

				export default class LocationBuilder {

Can you add a brief high-level description of what each class is for?

src/containers/locationBuilder.ts

					
				@ -0,0 +50,4 @@

				    this.conceptId = conceptId;

				  }

				  setName(name: string): LocationBuilder {

Excellent use of the Builder pattern 😎

src/containers/time/parsedTime.ts

					
				@ -0,0 +1,63 @@

				import ParsedTimeBase from "./parsedTimeBase";

Maybe replace this with property getters

Maybe replace this with [property getters](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Functions/get)

src/containers/time/parsedTimeBase.ts

					
				@ -0,0 +1,15 @@

				import type { TimeInfoType } from "../../utils/timeUtils";

getter here

src/containers/time/parsedTimeForDate.ts

					
				@ -0,0 +1,41 @@

				import {

getter here

gramliu (Migrated from github.com) approved these changes

2022-07-19 05:57:30 +00:00

gramliu (Migrated from github.com) left a comment

![image](https://user-images.githubusercontent.com/24856195/179676032-c8291730-8064-4ca4-9359-f08e4d3d18eb.png)

Sign in to join this conversation.

No reviewers

gramliu

No labels

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

ScottyLabs/dining-api!21

				`@ -0,0 +1,63 @@`
				`import ParsedTimeBase from "./parsedTimeBase";`

				`@ -0,0 +1,15 @@`
				`import type { TimeInfoType } from "../../utils/timeUtils";`

Rows
Columns