ScottyLabs/dalmatian
Watch
22
0
Fork
You've already forked dalmatian
 6
Code Issues 43 Pull requests 7 Projects Releases Packages Wiki Activity Actions

fix: quote role autocomplete values #241

Open
bpwang wants to merge 1 commit from fix/role-autocomplete-logical-operators into main
pull from: fix/role-autocomplete-logical-operators
merge into: ScottyLabs:main
Conversation 0 Commits 1 Files changed 1 +4 -4
bpwang commented 2026-09-28 01:16:44 +00:00
Member
Copy link

Fixes #218
Quotes role names returned by /role autocomplete so role names containing logical operators are treated as a single role name by the parser. Also removes the additional display quotes so the role is not displayed with duplicate quotation marks.
Testing

  • Tested /role members with roles containing and, or
  • Tested /role count
  • Tested compound expressions containing quoted role names

Side effect
Autocomplete now passes quoted role names into roleString. The lookup compares roleString against raw Discord role names. This appears to break single-role embed coloring. I left this unchanged for now.

Fixes #218 Quotes role names returned by /role autocomplete so role names containing logical operators are treated as a single role name by the parser. Also removes the additional display quotes so the role is not displayed with duplicate quotation marks. Testing - Tested /role members with roles containing and, or - Tested /role count - Tested compound expressions containing quoted role names Side effect Autocomplete now passes quoted role names into roleString. The lookup compares roleString against raw Discord role names. This appears to break single-role embed coloring. I left this unchanged for now.
fix: quote role autocomplete values
Some checks failed
CI / check-1 (pull_request) Failing after 8s
Details
CI / build (pull_request) Failing after 7s
Details
CI / check (pull_request) Failing after 0s
Details
kennel/build build succeeded
Details
ab4bc1df7e
Some checks failed
CI / check-1 (pull_request) Failing after 8s
Details
CI / build (pull_request) Failing after 7s
Details
CI / check (pull_request) Failing after 0s
Details
kennel/build build succeeded
Details
This pull request can be merged automatically.
This branch is out-of-date with the base branch
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin fix/role-autocomplete-logical-operators:fix/role-autocomplete-logical-operators
git switch fix/role-autocomplete-logical-operators

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch main
git merge --no-ff fix/role-autocomplete-logical-operators
git switch fix/role-autocomplete-logical-operators
git rebase main
git switch main
git merge --ff-only fix/role-autocomplete-logical-operators
git switch fix/role-autocomplete-logical-operators
git rebase main
git switch main
git merge --no-ff fix/role-autocomplete-logical-operators
git switch main
git merge --squash fix/role-autocomplete-logical-operators
git switch main
git merge --ff-only fix/role-autocomplete-logical-operators
git switch main
git merge fix/role-autocomplete-logical-operators
git push origin main
Sign in to join this conversation.
Reviewers
No reviewers
maybe-yiyi
tentype
Labels
Clear labels   
beginner friendly
Good for newcomers

  
bug
Something isn't working

  
chore
fixes that don't approximately result in a new feature

  
documentation
Improvements or additions to documentation

  
duplicate
This issue or pull request already exists

  
feature
New feature or request

  
help wanted
Extra attention is needed

  
invalid
This doesn't seem right

  
needs-triage
issue needs to be assessed by code-owner/leadership before open to implementation

  
question
Further information is requested

  
size/L

   
size/M

   
size/S

   
size/XL

   
size/XS

   
urgent

   
wontfix
This will not be worked on

  
needs/docs
Must have documentation written

  
needs/research
Discuss the ideal implementation with the tech lead

  
needs/upstream
Needs a contribution to an upstream project

  
type/bug
Something not working as intended

  
type/external
Lives outside of code

  
type/feature
New functionality

  
type/refactor
Improving existing code

  
urgency
high
 This is currently causing issues

  
urgency
immediate
 This is making a project or feature unusable

  
urgency
low
 This can happen whenever

  
urgency
medium
 This is expected to cause issues soon

No labels
beginner friendly
bug
chore
documentation
duplicate
feature
help wanted
invalid
needs-triage
question
size/L
size/M
size/S
size/XL
size/XS
urgent
wontfix
needs/docs
needs/research
needs/upstream
type/bug
type/external
type/feature
type/refactor
urgency
high
urgency
immediate
urgency
low
urgency
medium
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
ScottyLabs/dalmatian!241
No description provided.