Improve sidebar empty states #100
No reviewers
Labels
No labels
bug
chore
data
feature
frontend
good first issue
intermediate
needs/docs
needs/research
needs/upstream
type/bug
type/external
type/feature
type/refactor
urgency
high
urgency
immediate
urgency
low
urgency
medium
No milestone
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
ScottyLabs/cal!100
Loading…
Reference in a new issue
No description provided.
Delete branch "ni/emptystate"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Added 3 features:
No schedule: the sidebar explains that a schedule is needed first and points to "Create Schedule"
No courses: message plus an "Add a course" button that switches the section into edit mode
No clubs: message plus an "Add a club" button (edit mode) and a "Browse events" Link to /explore
All features work in light/dark mode
here is an example review that claude generated cause im too lazy lol. usually this is what a code review would look like tho, just to give you a feel with what to expect. in this case i just had claude do these fixes themself.
Nice first PR, @naemii. This covers everything in #25, and dark mode looks right. I ran it locally and tried all three states (no schedule, no courses, no clubs). A few things to fix before it merges, and some design suggestions.
Must fix
<h3><button aria-expanded>to a clickable<div>. Keyboard and screen-reader users can no longer open or close those sections. Keep the button version from main."Create Schedule"text uses typographic quotes, which the repo'sblock-ai-slophook rejects. Use plain".max-h-80 overflow-y-autoon the lists puts a second scroll area inside the scrolling sidebar. With a few courses, "My Courses" gets cut off after two items. It's outside this issue, so please drop it.Design suggestions
window.dispatchEvent(new Event("cmucal:create-schedule"))andNavbarlistens for it and callssetShowNewScheduleInput(true). Hide the two sections until there's a schedule.autoFocusto the search box, so clicking it lets you type straight away.Happy to pair on any of this. Push the changes to this branch and the PR will update.
View command line instructions
Checkout
From your project repository, check out a new branch and test the changes.