fix: inconsistent bg for searchbar in profile #35

Merged

klaipras merged 1 commit from klaipras-profile-searchbar into ui_change 2026-10-03 22:08:13 +00:00

Conversation 2 Commits 1 Files changed 1 +1 -1

klaipras commented 2026-09-26 20:25:07 +00:00

Member

Copy link

Description

Related Issue

Closes #34

Type of change

• Bug fix
• New feature
• Refactor / code improvement
• Test coverage
• Documentation

Testing

• I added/updated tests.
• I tested my changes locally.
  • I tested my changes with a laptop-size screen.
  • I tested my changes with a phone-size screen.
  • I tested my changes with a tablet-size screen.
• I tested on the dev app (dev.cmustudy.com)

Screenshots/Recordings

Checklist

• My code follows the project's existing style.
• I have reviewed my changes.
• Only the necessary files and lines have been changed.
• This PR is ready for review.

## Description ## Related Issue Closes #34 ## Type of change - [x] Bug fix - [ ] New feature - [ ] Refactor / code improvement - [ ] Test coverage - [ ] Documentation ## Testing - [x] I added/updated tests. - [x] I tested my changes locally. - [x] I tested my changes with a laptop-size screen. - [x] I tested my changes with a phone-size screen. - [x] I tested my changes with a tablet-size screen. - [ ] I tested on the dev app (dev.cmustudy.com) ## Screenshots/Recordings ## Checklist - [x] My code follows the project's existing style. - [x] I have reviewed my changes. - [x] Only the necessary files and lines have been changed. - [x] This PR is ready for review.

klaipras added 1 commit 2026-09-26 20:25:07 +00:00

fix: inconsistent bg for searchbar in profile ... efa1793ec4

change the input bg to transparent

klaipras changed title from fix: inconsistent bg for searchbar in profile to WIP: fix: inconsistent bg for searchbar in profile 2026-09-26 20:34:34 +00:00

klaipras changed title from WIP: fix: inconsistent bg for searchbar in profile to fix: inconsistent bg for searchbar in profile 2026-09-26 20:34:44 +00:00

klaipras requested reviews from annadavi, mishag, cseluzhy 2026-09-26 20:35:10 +00:00

klaipras added a new dependency 2026-09-26 21:41:45 +00:00

#34 My Courses search bar has consistent background color

annadavi force-pushed klaipras-profile-searchbar from efa1793ec4 to 0d0cf0377d 2026-09-28 02:04:40 +00:00 Compare

annadavi force-pushed klaipras-profile-searchbar from 0d0cf0377d to bce7664a5d 2026-09-28 02:54:43 +00:00 Compare

annadavi commented 2026-09-28 02:59:28 +00:00

Member

Copy link

I just added a PR template to the repo. In the future, it will automatically populate new PRs. Since this PR was made before the template existed, please just edit the description, copy the following template into it, and fill in the template:

## Description



## Related Issue


Closes #

## Type of change

- [ ] Bug fix
- [ ] New feature
- [ ] Refactor / code improvement
- [ ] Test coverage
- [ ] Documentation

## Testing

- [ ] I added/updated tests.
- [ ] I tested my changes locally.
    - [ ] I tested my changes with a laptop-size screen.
    - [ ] I tested my changes with a phone-size screen.
    - [ ] I tested my changes with a tablet-size screen.
- [ ] I tested on the dev app (dev.cmustudy.com)

## Screenshots/Recordings



## Checklist

- [ ] My code follows the project's existing style.
- [ ] I have reviewed my changes.
- [ ] Only the necessary files and lines have been changed.
- [ ] This PR is ready for review.

I just added a PR template to the repo. In the future, it will automatically populate new PRs. Since this PR was made before the template existed, please just edit the description, copy the following template into it, and fill in the template: <pre> ## Description <!-- Please provide a description of the issue, the changes you made to fix it, and why they work. It is expected that you understand why your changes work and if you do not understand why at least say as much so a maintainer knows how much to value the PR. No AI slop. --> ## Related Issue <!-- Link the issue this PR addresses, if applicable. --> Closes # ## Type of change - [ ] Bug fix - [ ] New feature - [ ] Refactor / code improvement - [ ] Test coverage - [ ] Documentation ## Testing - [ ] I added/updated tests. - [ ] I tested my changes locally. - [ ] I tested my changes with a laptop-size screen. - [ ] I tested my changes with a phone-size screen. - [ ] I tested my changes with a tablet-size screen. - [ ] I tested on the dev app (dev.cmustudy.com) ## Screenshots/Recordings <!-- If this includes a UI change, attach screenshots on both laptop and mobile. --> ## Checklist - [ ] My code follows the project's existing style. - [ ] I have reviewed my changes. - [ ] Only the necessary files and lines have been changed. - [ ] This PR is ready for review. </pre>

annadavi approved these changes 2026-10-03 22:03:52 +00:00

annadavi left a comment

Copy link

Remember to rebase (or merge) ui_change into this branch before merging it into main. You should be able to do it from this page using the update dropdown.

Remember to rebase (or merge) ui_change into this branch before merging it into main. You should be able to do it from this page using the update dropdown.

klaipras merged commit 409036b57a into ui_change 2026-10-03 22:08:13 +00:00

klaipras referenced this pull request from a commit 2026-10-03 22:08:14 +00:00

Merge pull request 'fix: inconsistent bg for searchbar in profile' (#35) from klaipras-profile-searchbar into ui_change

klaipras deleted branch klaipras-profile-searchbar 2026-10-03 22:09:01 +00:00

Sign in to join this conversation.

Reviewers

No reviewers

mishag

cseluzhy

annadavi

Labels

Clear labels   

first-task

  

needs/docs

Must have documentation written

  

needs/research

Discuss the ideal implementation with the tech lead

  

needs/upstream

Needs a contribution to an upstream project

  

type/bug

Something not working as intended

  

type/external

Lives outside of code

  

type/feature

New functionality

  

type/refactor

Improving existing code

  

urgency

high

This is currently causing issues

  

urgency

immediate

This is making a project or feature unusable

  

urgency

low

This can happen whenever

  

urgency

medium

This is expected to cause issues soon

No labels

first-task

needs/docs

needs/research

needs/upstream

type/bug

type/external

type/feature

type/refactor

urgency

high

urgency

immediate

urgency

low

urgency

medium

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Depends on

#34 My Courses search bar has consistent background color

ScottyLabs/study

Reference

ScottyLabs/study!35

No description provided.