Add intermediate placeholder for profiles page #92
Labels
No labels
backend
beginner friendly
bug
chore
documentation
enhancement
frontend
needs-triage
no-stale
priority/high
priority/low
priority/medium
size/L
size/M
size/S
size/XL
size/XS
stage/backlog
stage/done
stage/in progress
stage/in-progress
stage/ready
stale
wontfix
needs/docs
needs/research
needs/upstream
type/bug
type/external
type/feature
type/refactor
urgency
high
urgency
immediate
urgency
low
urgency
medium
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
ScottyLabs/housing#92
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Overall Objective
apps/frontend/src/components/Navbar.tsxrenders a profile avatar that links to/profile. There is no/profileroute registered inapps/frontend/src/App.tsx, so clicking it drops the user on the 404 page.This issue is the placeholder. Here we just want the route to exist and render something in the mean time, the same way
apps/frontend/src/app/reviews/page.tsxcurrently says "Coming soon!". Consistency here with our coming soon pages would be nice.Later we'll get a design for the profile page when reviews data and other data can be added.
Suggested Approach
apps/frontend/src/app/profile/page.tsx. Copy the shape ofapps/frontend/src/app/reviews/page.tsx, same wrapper classes, same heading treatment, so it looks like it belongs. We want them to look the same prettymuch.apps/frontend/src/App.tsx. Add<Route path="/profile" element={<Profile />} />alongside the others, and import it with the@/alias like the rest do./api/auth/loginrather than showing an empty shell. Look at howapps/frontend/src/app/launch-page/page.tsxlinks to the login endpoint. It's a plain<a href>, not a react-router<Link>, because it's a server redirect and not a client route. If ya don't do that it might break.cd apps/frontendanddeno task dev, click the avatar in both the desktop navbar and the mobile one and confirm both land on the new page.Help & Resources