Swap out Roommates tab for Reviews tab #58
Labels
No labels
backend
beginner friendly
bug
chore
documentation
enhancement
frontend
needs-triage
no-stale
priority/high
priority/low
priority/medium
size/L
size/M
size/S
size/XL
size/XS
stage/backlog
stage/done
stage/in progress
stage/in-progress
stage/ready
stale
wontfix
needs/docs
needs/research
needs/upstream
type/bug
type/external
type/feature
type/refactor
urgency
high
urgency
immediate
urgency
low
urgency
medium
No milestone
No project
No assignees
3 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
ScottyLabs/housing#58
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Overall Objective
The navbar (apps/frontend/src/components/Navbar.tsx) currently has a "Roommates" tab that links to /roommates. That route isn't actually registered in App.tsx, so clicking it currently falls through to the catch-all * route and shows the generic 404 page (apps/frontend/src/app/not-found.tsx, "We couldn't find that page"). We want to repurpose this tab as "Reviews" instead, and give it a proper placeholder page instead of the 404.
For the placeholder page instead of 404 have it say Coming Soon!
Suggested Approach
Navbar.tsx, find theNavButtonwithhref="/roommates"andname="Roommates"(around line 51). Change thehrefto/reviews, thenameto"Reviews", and swap the icon to something more fitting than/person.svg(check thepublicfolder for existing icons, or ask if we need a new one).NavbarSpacercomponents next to it (right_nbr_path="/roommates"andleft_nbr_path="/roommates") to use/reviewsinstead, so the spacing between nav items still lines up.apps/frontend/src/app/reviews/page.tsx. Keep it simple for now, a heading like "Reviews" and a short message like "Reviews are coming soon!" is enough. You can loosely model the layout onapps/frontend/src/app/map-page.tsxsince that's a simple single-purpose page.App.tsx, import your new page and add a route for it:<Route path="/reviews" element={<Reviews />} />, placed above the catch-all*route.Help & Resources
No activity here for 21 days. If this is still live, drop a comment or push something and I'll clear the label. Otherwise it'll be unassigned on the next sweep.
this seems to already be done?
Still no movement, so I'm unassigning this and putting it back up for grabs. Comment here if you're still on it and want it back.
im on it i want it back
wait this does seem to be done
also that's a bot btw LMAO
oh lMAO
looks to be done am closing!