Add UI for apartment style housing #122
Labels
No labels
backend
beginner friendly
bug
chore
documentation
enhancement
frontend
needs-triage
no-stale
priority/high
priority/low
priority/medium
size/L
size/M
size/S
size/XL
size/XS
stage/backlog
stage/done
stage/in progress
stage/in-progress
stage/ready
stale
wontfix
needs/docs
needs/research
needs/upstream
type/bug
type/external
type/feature
type/refactor
urgency
high
urgency
immediate
urgency
low
urgency
medium
No milestone
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
ScottyLabs/housing#122
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Overall Objective
The building detail page handles the new upperclassmen apartments, but the comparison page does not. The result is that there appears to not have roomtypes for comparisons page for the new dorms.
apps/frontend/src/components/BuildingComparison.tsxrenders room types with a chain ofincludes()checks that stops atRoomType.SemiSuiteTriple. Four room types are missing entirely:SemiSuiteQuadApartmentTripleStudioApartmentSingleStudioApartmentDoubleapps/frontend/src/components/BuildingDetails.tsxalready renders all ten (lines 74 to 223), so the correct markup already exists in the codebase. This is mostly a matter of bringing the two components into agreement. So feel free to reference that.Suggested Approach
apps/frontend/src/components/BuildingComparison.tsxand find the Room Types card. Then openapps/frontend/src/components/BuildingDetails.tsxand compare the two blocks side by side so you can see exactly what is missing.Help & Resources
i fisnisehd and it was merged