Add UI for apartment style housing #122

Closed
opened 2026-10-26 16:44:57 +00:00 by gostmeaper · 1 comment
Member

Overall Objective

The building detail page handles the new upperclassmen apartments, but the comparison page does not. The result is that there appears to not have roomtypes for comparisons page for the new dorms.

apps/frontend/src/components/BuildingComparison.tsx renders room types with a chain of includes() checks that stops at RoomType.SemiSuiteTriple. Four room types are missing entirely:

  • SemiSuiteQuad
  • ApartmentTriple
  • StudioApartmentSingle
  • StudioApartmentDouble

apps/frontend/src/components/BuildingDetails.tsx already renders all ten (lines 74 to 223), so the correct markup already exists in the codebase. This is mostly a matter of bringing the two components into agreement. So feel free to reference that.

Suggested Approach

  1. Open apps/frontend/src/components/BuildingComparison.tsx and find the Room Types card. Then open apps/frontend/src/components/BuildingDetails.tsx and compare the two blocks side by side so you can see exactly what is missing.
  2. Add the four missing room types to the comparison component, matching the labels BuildingDetails uses so the two pages agree: "Semi-Suite Quad", "Apartment Triple", "Studio Apartment Single", "Studio Apartment Double".

Help & Resources

### Overall Objective The building detail page handles the new upperclassmen apartments, but the comparison page does not. The result is that there appears to not have roomtypes for comparisons page for the new dorms. `apps/frontend/src/components/BuildingComparison.tsx` renders room types with a chain of `includes()` checks that stops at `RoomType.SemiSuiteTriple`. Four room types are missing entirely: - `SemiSuiteQuad` - `ApartmentTriple` - `StudioApartmentSingle` - `StudioApartmentDouble` `apps/frontend/src/components/BuildingDetails.tsx` already renders all ten (lines 74 to 223), so the correct markup already exists in the codebase. This is mostly a matter of bringing the two components into agreement. So feel free to reference that. ### Suggested Approach 1. Open `apps/frontend/src/components/BuildingComparison.tsx` and find the Room Types card. Then open `apps/frontend/src/components/BuildingDetails.tsx` and compare the two blocks side by side so you can see exactly what is missing. 2. Add the four missing room types to the comparison component, matching the labels BuildingDetails uses so the two pages agree: "Semi-Suite Quad", "Apartment Triple", "Studio Apartment Single", "Studio Apartment Double". ### Help & Resources - [README](../../ScottyLabs/housing/src/branch/main/README.md) - [Contributing Guidelines](../../ScottyLabs/housing/src/branch/main/docs/CONTRIBUTING.md)
zoexue self-assigned this 2026-10-31 23:19:00 +00:00
Member

i fisnisehd and it was merged

i fisnisehd and it was merged
Sign in to join this conversation.
No milestone
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
ScottyLabs/housing#122
No description provided.