ScottyLabs/eats
Watch
7
0
Fork
You've already forked eats
 1
Code Issues 48 Pull requests 7 Projects 1 Releases Packages Wiki Activity Actions

Ad Banner Localstorage update #682

New issue
Open
opened 2025-09-09 21:05:23 +00:00 by laasyaaki · 1 comment
laasyaaki commented 2025-09-09 21:05:23 +00:00 (Migrated from github.com)
Copy link

Currently on CMUEats we store pinned cards and ad banner open/close in local storage. However, when we change the ad banner, we want all of our users to see it, even if they have closed the banner. We want the ad banner to be open again when a new ad is pushed.

Currently on CMUEats we store pinned cards and ad banner open/close in local storage. However, when we change the ad banner, we want all of our users to see it, even if they have closed the banner. We want the ad banner to be open again when a new ad is pushed.
sanajitjana commented 2025-09-10 10:10:42 +00:00 (Migrated from github.com)
Copy link

Hi @laasyaaki, It's possible by simply storing the current ad version in local storage and resetting isAdClosed when the version changes. Let me know if you want me to contribute to implementing this or if you have any other ideas in mind.

Hi @laasyaaki, It's possible by simply storing the current ad version in local storage and resetting isAdClosed when the version changes. Let me know if you want me to contribute to implementing this or if you have any other ideas in mind.
👍 1
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
kennel-no-mapkit-backend
eats-kennel
Issue#833Fix
issue-843-active-filter
staging
unblocking-search-bar
sort-by-rating
cirex-web-patch-1
copilot/add-user-settings-feature
uncorrupted-version
raffle_greeting
tweaks/mobile-drawer
sort-locations-by-distance
edit-readme
delete
remove_collegecart_cards
revert-812-feat/collegecart-theme-apr-11-13
searchable_menus
ui/refactored-mobile-redesign-staged
ox-tooling
april-fools-2026
grubhub_links
rating-display
sort-by-distance
easter-theme
map-filter
feat/gallo-perm-close
feat/miku-day-2026
bruh3
report-system
valentines
review_system_promo_banner
banner-component
card-header-dropdown
listpage-offline-alert-fix
feat/review-system
compact-mode-style-tweaks
wrapped-analysis-2025
search-bar-query-delay
context-refactor-uhh
copilot/sub-pr-741
copilot/sub-pr-741-again
block_periods
eatery-card-refactor
sponsor_carousel
ui/refactored-mobile-redesign
google_auth
banner-update
chore/tiny-refactor
style/tweak-pin-and-hide-buttons
card-refactor
bye_nova_25
hide-location
add_nova_banner
swtich_to_pnpm
schatz-menu-link
ui/mobile-redesign
fix/search-bar
increase_form_visibility
feat/pinned-cards-on-map
feat/banner
copilot/fix-13c3c122-a651-43d2-8d62-56ddf22bdcf1
copilot/fix-9c1d6fe9-b606-44d1-a5b1-a90f3133e0b9
fix/error-reporting-2
fix/error-reporting
fix/time-sorting
fix/weekly-times
Readme
bruh2
chore/update-staging
staging-reset
fix/404
update-footer
literally-a-single-line-change-unless-I-reset-wrong
fix/copilot-suggestions
test/pwa
fix/pwa
fix/dot-flashing
fix/env
feature/dynamic-email-contacts
Fix-readme
star_items_v2
quick-fix
chore/upd-staging
Yuxiang-Huang-patch-2
Yuxiang-Huang-patch-1
emergency-url-fix
tsurbs-patch-1
Footer-link
Footer-name
style/code-cleanup
style/times-popup
fix/map-color
timesdatesbetter-hurebranch2
fix/aaaaaaaa
bruh
fix/a-bit-of-refactoring
april-fools
time_filter
location-filter
star_items
cmueats_filters_food
style/a-bit-of-animation
evelyn-branch
map-almost-closed-view
feedback-form
nutrition-details
discard
hurebranch
alex_branch
no-merge
css-improvements-2
railway-test
nicolas/fix-ci
nettlin/update-email
update-mapkit-js-token
fix-menus
fix-specials
nettlin/add-map
nettlin/fix-css-syntax
modern-react
No results found.
Labels
Clear labels   
bad first issue

   
bootcamp
Bootcamp Task

  
bug
Something isn't working

  
cmueats 2.0

   
codebase
Codebase or developer experience (DX) improvements

  
complexity: low

   
complexity: medium

   
complexity: nontrivial

   
dependencies
Pull requests that update a dependency file

  
design needed

   
documentation
Improvements or additions to documentation

  
duplicate
This issue or pull request already exists

  
enhancement
New feature or request

  
github_actions
Pull requests that update GitHub Actions code

  
good first issue
Good for newcomers

  
help wanted
Extra attention is needed

  
high priority

   
important

   
invalid
This doesn't seem right

  
javascript
Pull requests that update JavaScript code

  
low pri

   
math heavy

   
outdated
The pull request is outdated and there's a newer pull request for the issue

  
question
Further information is requested

  
theory heavy

   
typescript
Pull requests that update TypeScript code

  
ui/ux
UI and/or UX improvements

  
wontfix
This will not be worked on

  
needs/docs
Must have documentation written

  
needs/research
Discuss the ideal implementation with the tech lead

  
needs/upstream
Needs a contribution to an upstream project

  
type/bug
Something not working as intended

  
type/external
Lives outside of code

  
type/feature
New functionality

  
type/refactor
Improving existing code

  
urgency
high
 This is currently causing issues

  
urgency
immediate
 This is making a project or feature unusable

  
urgency
low
 This can happen whenever

  
urgency
medium
 This is expected to cause issues soon

No labels
bad first issue
bootcamp
bug
cmueats 2.0
codebase
complexity: low
complexity: medium
complexity: nontrivial
dependencies
design needed
documentation
duplicate
enhancement
github_actions
good first issue
help wanted
high priority
important
invalid
javascript
low pri
math heavy
outdated
question
theory heavy
typescript
ui/ux
wontfix
needs/docs
needs/research
needs/upstream
type/bug
type/external
type/feature
type/refactor
urgency
high
urgency
immediate
urgency
low
urgency
medium
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
ScottyLabs/eats#682
No description provided.