"Learn more" on Explore does nothing on desktop #60

Open
opened 2026-10-03 19:44:42 +00:00 by jalenluorion · 0 comments
Member

What's wrong
On a desktop-width window, clicking "Learn more" on an Explore result does nothing. At phone width the details modal opens.

How to reproduce

  1. Use a window wider than 768px and open /explore (if the list is empty, pick January 12, 2026 in the date filter; see "Explore shows no events by default").
  2. Click "Learn more" on any result: nothing opens.
  3. Make the window narrower than 768px and click it again: the modal opens.

Expected
"Learn more" opens the event details at every width.

Where to look

  • web/src/app/components/SearchResultSidebar.tsx: the button calls openDetails(event.id, event) with no position.
  • web/src/app/components/ModalRender.tsx: on desktop only EventPopover is visible; ModalEvent sits inside a md:hidden wrapper.
  • web/src/app/components/EventPopover.tsx: if (!position) return null.
  • web/src/app/components/Calendar.tsx: handleEventClick shows how a position is built from getBoundingClientRect().
  • Either pass a position built from the button (e.currentTarget.getBoundingClientRect()), or make ModalRender show ModalEvent on desktop when popoverPosition is null.

Done when

  • "Learn more" opens details at desktop and mobile widths.
  • Clicking an event on the calendar still opens the popover next to that event.
**What's wrong** On a desktop-width window, clicking "Learn more" on an Explore result does nothing. At phone width the details modal opens. **How to reproduce** 1. Use a window wider than 768px and open /explore (if the list is empty, pick January 12, 2026 in the date filter; see "Explore shows no events by default"). 2. Click "Learn more" on any result: nothing opens. 3. Make the window narrower than 768px and click it again: the modal opens. **Expected** "Learn more" opens the event details at every width. **Where to look** - `web/src/app/components/SearchResultSidebar.tsx`: the button calls `openDetails(event.id, event)` with no position. - `web/src/app/components/ModalRender.tsx`: on desktop only `EventPopover` is visible; `ModalEvent` sits inside a `md:hidden` wrapper. - `web/src/app/components/EventPopover.tsx`: `if (!position) return null`. - `web/src/app/components/Calendar.tsx`: `handleEventClick` shows how a position is built from `getBoundingClientRect()`. - Either pass a position built from the button (`e.currentTarget.getBoundingClientRect()`), or make ModalRender show `ModalEvent` on desktop when `popoverPosition` is null. **Done when** - [ ] "Learn more" opens details at desktop and mobile widths. - [ ] Clicking an event on the calendar still opens the popover next to that event.
jalenluorion added this to the Phase 2 milestone 2026-10-03 19:44:42 +00:00
jalenluorion added this to the CMUCal project 2026-10-03 19:45:09 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
ScottyLabs/cal#60
No description provided.