"Learn more" on Explore does nothing on desktop #60
Labels
No labels
bug
chore
data
feature
frontend
good first issue
intermediate
needs/docs
needs/research
needs/upstream
type/bug
type/external
type/feature
type/refactor
urgency
high
urgency
immediate
urgency
low
urgency
medium
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
ScottyLabs/cal#60
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
What's wrong
On a desktop-width window, clicking "Learn more" on an Explore result does nothing. At phone width the details modal opens.
How to reproduce
Expected
"Learn more" opens the event details at every width.
Where to look
web/src/app/components/SearchResultSidebar.tsx: the button callsopenDetails(event.id, event)with no position.web/src/app/components/ModalRender.tsx: on desktop onlyEventPopoveris visible;ModalEventsits inside amd:hiddenwrapper.web/src/app/components/EventPopover.tsx:if (!position) return null.web/src/app/components/Calendar.tsx:handleEventClickshows how a position is built fromgetBoundingClientRect().e.currentTarget.getBoundingClientRect()), or make ModalRender showModalEventon desktop whenpopoverPositionis null.Done when