Upload form forgets the event type you picked #52

New issue

Open

opened 2026-10-03 19:44:41 +00:00 by jalenluorion · 0 comments

jalenluorion commented

2026-10-03 19:44:41 +00:00

Member

What's wrong
In the Upload flow, the event type picked on the "Upload to ..." step is lost: the next form opens with no type selected, so you have to pick it again.

How to reproduce

Click Upload, choose a calendar and click Next.
Click "Manually fill out the form", then click "Career".
Click Continue: the form opens with no event type highlighted.

Expected
The form opens with the type you already picked.

Where to look

web/src/app/components/ModalEventLink.tsx: openUpload(selectedCategory, selectedEventType) stores the type in modalData.eventType.
web/src/app/components/ModalRender.tsx: renders <ModalEventForm> without eventType={modalData.eventType}.
web/src/app/components/ModalEventForm.tsx: already accepts an optional eventType prop and uses it as the initial selectedEventType.
Also in ModalEventLink: clicking "Manually fill out the form" calls reset(), which clears a type picked before it. Keep the type when switching to manual.

Done when

The picked type is preselected in the form, whichever order you click in.
Changing the type in the form still works.

**What's wrong** In the Upload flow, the event type picked on the "Upload to ..." step is lost: the next form opens with no type selected, so you have to pick it again. **How to reproduce** 1. Click Upload, choose a calendar and click Next. 2. Click "Manually fill out the form", then click "Career". 3. Click Continue: the form opens with no event type highlighted. **Expected** The form opens with the type you already picked. **Where to look** - `web/src/app/components/ModalEventLink.tsx`: `openUpload(selectedCategory, selectedEventType)` stores the type in `modalData.eventType`. - `web/src/app/components/ModalRender.tsx`: renders `<ModalEventForm>` without `eventType={modalData.eventType}`. - `web/src/app/components/ModalEventForm.tsx`: already accepts an optional `eventType` prop and uses it as the initial `selectedEventType`. - Also in ModalEventLink: clicking "Manually fill out the form" calls `reset()`, which clears a type picked before it. Keep the type when switching to manual. **Done when** - [ ] The picked type is preselected in the form, whichever order you click in. - [ ] Changing the type in the form still works.

jalenluorion added this to the Phase 1 milestone

2026-10-03 19:44:41 +00:00

jalenluorion added the

good first issue

bug

frontend

labels

2026-10-03 19:44:41 +00:00

jalenluorion added this to the CMUCal project

2026-10-03 19:45:09 +00:00